Help: Eloquent save() stopped working

Is it saving to the database? I have never used $user->save() in an if statement because that code shouldn't exacute just evaluate to true or false. I always pass the object in (this case $user) after it's created. If it isn't saved then it will evaluate to false. If a new object was created it should evaluate to true.

I've written the following test:

$user = User::find(6);

var_dump($user->save());

$user->firstname = 'David';

var_dump($user->save());

$user->firstname = 'Different';

var_dump($user->save());

which returns

boolean false
boolean false
boolean true

So, it would appear Eloquent returns false when nothing was changed from the original model.

I think this is new behaviour on Eloquent but i'll keep looking into it.

Fixed - I think!

Turns out a PR this week broke the return of the save method - https://github.com/laravel/framework/commit/edd357dafd804b61446537e7c5f22ddac7bef271.

Taylor already fixed - https://github.com/laravel/framework/commit/34b86ebd2990e4908209a27bcf1eff4693d8acda - so a composer update sorted it out.

Whew.

What does it return if you do the following?

$user = User::find(6);
$user->firstname = 'David';
$user->save();

dd($user);

@Erik - I got it fixed, thanks.

Why are you wrapping save method in if statement? It will not return false in 99% of times. If something will go wrong, PDOException will be thrown.

Save will return false only if "saving" event will return false, and that will never happen if you specially don't do it yourself.

Hey, @sukonovs.

It's a practice I follow in all my repositories, throwing a StorageException if I can't guarantee the model was saved, therefore halting any code that expects there to be something to to work with (saving relationships, redirecting to ID, etc).

I understand that a PDOException would be thrown for MySQL errors, but in this case save was returning false so my code caught this and I was alerted.