Variable scope in a condition

@Snapey Yes that's true ... I really wonder why my array is empty whereas I do have to retrieve an error.

@vincent15000 try print_r($item) inside loop

@Snapey I see the right values for the item inside the loop. The error is added to the array inside the loop and the condition (checked with print_r), but once out of the condition and the loop, the array is empty.

And if I add the error into the array inside the loop but outside the condition, the error is visible outside the loop.

Very strange ...

@Snapey What can I check to understand where the problem is ?

@vincent15000 because this line return value is unexpected

if ($item != $some_test_value) {

can you show the full code

@newbie360 @snapey Here is the full code. I need this to compare the old code and the new code to check if I obtain the same datas. So I retrieve an object in the databse with its properties, I create another object and I run the calculation with the new code and then I check if both objects have the same values.

// rerefence with ORIGINAL code
$object = new Object($object_id);

// test to check if the new calculation code is ok
$testObject = new Object;
$testObject->calculate();

// now I compare both objects ($object and $test)

$fields = [
	'start_date',
	'end_date',
	'property_1',
	'property_2',
	...
];

$validation = true;

$errors = [];
$errors[] = ['id', 'field', 'old', 'test', 'gap']; // here the idea is to save the errors into a CSV file

foreach ($fields as $field) {
	if ($object->$field != $testObject->$field) {
		$validation = false;

		if ($field == 'start_date' || $field == 'end_date') {
			$gap = null;
		} else {
			$gap = round(($object->$field - $testObject->$field) / $testObject->$field * 100, 1).' %';
		}

		var_dump('ID : '.$object_id.PHP_EOL);
		var_dump('FIELD : '.$field.PHP_EOL);
		var_dump('ORIGINAL : '.$object->$field.PHP_EOL);
		var_dump('TEST : '.$testObject->$field.PHP_EOL);
		var_dump('GAP : '.$gap.PHP_EOL);

		$errors[] = [
			$object_id,
			$field,
			$object->$field,
			$testObject->$field,
			$gap,
		];

		print_r($errors); // IS OK => I SEE THE ERROR ADDED TO THE ARRAY
	}
}

print_r($errors); // IS NOT OK => I DON'T SEE THE ERROR ADDED TO THE ARRAY

@vincent15000 i can't see any code overwrite the $errors, you may try debug it line by line

// rerefence with ORIGINAL code
// $object = new Object($object_id);

// test to check if the new calculation code is ok
// $testObject = new Object;
// $testObject->calculate();

// now I compare both objects ($object and $test)

$fields = [
	'start_date',
	'end_date',
	'property_1',
	'property_2',
	// ...
];

// $validation = true;

$errors = [];
$errors[] = ['id', 'field', 'old', 'test', 'gap'];

foreach ($fields as $field) {
	// if ($object->{$field} != $testObject->{$field}) {
	if (true) {
		// $validation = false;

		if ($field == 'start_date' || $field == 'end_date') {
			$gap = null;
		} else {
			// $gap = round(($object->{$field} - $testObject->{$field}) / $testObject->{$field} * 100, 1).' %';
			$gap = 'gap_number';
		}

		// var_dump('ID : '.$object_id.PHP_EOL);
		// var_dump('FIELD : '.$field.PHP_EOL);
		// var_dump('ORIGINAL : '.$object->{$field}.PHP_EOL);
		// var_dump('TEST : '.$testObject->{$field}.PHP_EOL);
		// var_dump('GAP : '.$gap.PHP_EOL);

		$errors[] = [
			// 'object_id' => $object_id,
			'field' => $field,
			// 'object_field' => $object->{$field},
			// 'testobject_field' => $testObject->{$field},
			'gap' => $gap,
		];

		info('inside', $errors);
        // print_r($errors);
	}
}

info('outside', $errors);
// print_r($errors);

@newbie360 That's exactly what I have done, but I don't find anything that could help me.

@vincent15000 with my code, in the log i can see both message, no idea whats wrong @@

you have initialize the $errors variable, i don't know why LOL