API Resource mergeWhen with conditional whenLoaded

I have lazy loading disabled and I'm trying to do this in an API Resource but whenLoaded is always evaluating to true. Any suggestions? I'm getting an error that I'm trying to lazy load rateable but expected whenLoaded would return false

public function toArray($request)
    {
        return [
            'id' => $this->id,
            'expense_category_id' => $this->expense_category_id,
            'quantity' => $this->quantity,
            'task_category_id' => $this->task_category_id,
            $this->mergeWhen($this->whenLoaded('rateable'), [
                'rate' => $this->rateable->rate,
                'extended' => $this->rateable->rate * $this->quantity
            ])
        ];
    }

Sinnbeck

3 years ago

Best Answer

Level 102

You need to use a function (closure) for the actual returning of the relationship. Otherwise php will run it.

1 like

Brian Kidd

3 years ago

Level 27

@Sinnbeck Thanks, didn't realize I could pass a closure as a condition.

tisuchi

3 years ago

Level 70

@brian kidd Does it work?

public function toArray($request)
    {
        $result = [
            'id' => $this->id,
            'expense_category_id' => $this->expense_category_id,
            'quantity' => $this->quantity,
            'task_category_id' => $this->task_category_id,
        ];

        if ($this->relationLoaded('rateable')) {
            $result = array_merge($result, [
                'rate' => $this->rateable->rate,
                'extended' => $this->rateable->rate * $this->quantity
            ]);
        }

        return $result;
    }

Instead of using $this->mergeWhen method, I use the relationLoaded method to check if the rateable relation is loaded and add the relevant information to the array.

Please or to participate in this conversation.