Carbon::createFromFormat issue

What do $request->date and $request->time look like?

$date = $request->date;

dd($date);

"2019-12-30"

$time = $request->time;

dd($time);

"10:40"

Agree the Carbon instance looks odd, but if you output the items in your query they do seem to be giving you the data in the way you want.

$requestedTime->format('Y-m-d')
outputs "2019-12-30"


$requestedTime->format('H:i');
outputs "10:40"

What are you trying to find in the second query? You appear to be searching for a time that is both equal to or less than and greater than or equal to in the same query. Isn't that the same as time = to something?

$query
   ->where('time', '>=', $requestedTime->format('H:i'))
   ->where('time', '<=', $requestedTime->format('H:i'));

is the same as

$query
   ->where('time', '>=', "10:40")
   ->where('time', '<=', "10:40");

which is the same as

$query
   ->where('time', "10:40");

How are you storing dates/times in your database?

Trying to implement a simple meeting logic, and check if the $requestedTime exists for this $doctor, if not create the meeting.

$this->validate($request, [
        'date' => 'max:50|required', 
        'time' => 'date_format:H:i|max:140|required',  
]);


$date = Carbon\Carbon::createFromFormat('Y-m-d H:i', $request->date . $request->time);
$requestedTime = $date;
$requestedDoctorId = $request->get('doctor_id'); 
// (Doctor.php, Method: meetings(return $this->hasMany(Meeting::class, 'doctor_id');))

$doctor = Doctor::where('id', $requestedDoctorId)
      ->whereDoesntHave('meetings', function ($query) use ($requestedTime) {
        $query
        ->where('date', $requestedTime->format('Y-m-d'));
        $query
        ->where('time', '>=', $requestedTime->format('H:i'))
        ->where('time', '<=', $requestedTime->format('H:i'));
 });

if ($doctor instanceof Doctor) {
    
// This doctor is available
// create meeting 
}else{

// doctor is not available
// e.g. return redirect back with info not available

}

But somehow, even if there is no meeting on the $requestedTime it redirects back with the info not available.

I always just use eloquent for querying the database, so im not overly familiar with query builder etc, but are you pulling in Illuminate\Database\Eloquent\Builder?

I also wonder if the two $query items should be chained into a single $query? Don't you also need a retrieval method on the end of the query (->get(), ->first())? In the docs the example uses ->get().

$doctor = Doctor::where('id', $requestedDoctorId)
      ->whereDoesntHave('meetings', function ($query) use ($requestedTime) {
        $query
        ->where('date', $requestedTime->format('Y-m-d'))
        ->where('time', '=', $requestedTime->format('H:i'));
 }->get());

What column types are you using to store the dates/times?

I see in the docs that there are some additinoal where clauses that might be of assistance as well i.e. whereDate / whereTime

What column types are you using to store the dates/times?

$table->date('date');
$table->time('time');

If I add get() like

 })->get();

it just returns the Staff Model. As I am checking whereDoesntHave, I thought that I don't need to get the collection, and only check the instance, and else redirect back.

But it just won't work.

You might be right re: checking whether its an instance of - ive never seen/tried that, but i guess end result would be the same.

What does the meetings table look like? Presumably you are storing the doctor_id in that table?

Yes, storing the doctor_id, as an unsignedInteger within the meetings_table.

If you query that table directly - can you get the result you want (i.e. prove the subquery - via query builder is valid)?

Once that can be established you could then rework into whereDoesntHave method again?

I don't think you understand what createFromFormat does.

It creates a Carbon instance at a specific time. That time includes seconds, milliseconds and the timezone

The response you see in the first question is exactly what I would expect

Ok, but even if I use $request within my $query:

->whereDoesntHave('meetings', function ($query) use ($request) {
        $query
        ->where('date', $request->date)  
        ->where('time', '=',  $request->time);

and then check on the Doctor instance, it will redirect back with the info not available, even though there are no meetings for the chosen date/ time.

Where could it fail?

Why even bother with Carbon?

$doctor = Doctor::where('id', $request->doctor_id)
      ->whereDoesntHave('meetings', function ($query) use ($request) {
        $query
        ->where('date', $request->date)
        ->where('time', $request->time)
     })->first();