hasFile() no longer works

This was working perfectly under 5.3.

I just upgraded to 5.4 and can no longer upload files using the hasFile() method. The check is ignored

public function addPhotos(Request $request)
{
    // dd($request) here shows a file in the fileBag

    if ($request->hasFile('photo'))
    {
        // dd($request) here never prints, this block is passed over as if the file doesn't exist
    }
}

Any ideas?

jekinney

9 years ago

Level 47

Definitely still there.

https://laravel.com/docs/5.4/requests#files

Now make sure the file system dependencies are updated too. League/filesystem if I remember right.

timgavin

9 years ago

Level 11

League/flysystem is part of the core, isn't it? Shouldn't it be updated automatically? I don't see a reference to it in composer.json.

jekinney

9 years ago

Level 47

Yes but sometimes it may not for whatever reason. For example when I deploy I hard code the exact release version just in case someone clones the master and then has issues like your having on the upgrade.

timgavin

9 years ago

Level 11

How would you suggest I do this? Wouldn't running composer require league/flysystem install it outside of the core?

timgavin

9 years ago

Level 11

After more testing it appears that the file I was trying to upload was not valid, which is weird because I've been able to not only open and view it, but upload it to Twitter.

Don't know why Laravel thinks it's not a valid JPG...

Thanks for your help, @jekinney :)

1 like

Please or to participate in this conversation.