Generate Clean SEO URL

Well you can do that with using route parameters.

But you still have pagination as query string:

somesite.com/whatever/something?page=2

SEO has nothing to do with query string, what you refer to is just "friendly" url.

How can i generate friendly url making it go from http://localhost:8000/news?tags=1 to http://localhost:8000/news/entertainment

My Database Has tow Tags Now

ID Name 1 News 2 Entertainment

So using my current url http://localhost:8000/news?tags=1 i want it to be like this instead

http://localhost:8000/news/entertainment or http://localhost:8000/entertainment

Routes:

Route::get('/{tag?}', 'NewsController@index')->name('news.index');

Controller:

public function index(Request $request, $tag = null)
{   
    if($tag){
        $news = Tag::where('name', $tag)->firstOrFail()->news;
    }else{
        $news = News::paginate(15);
    }
    return view('categories.news', compact('news'));
}

Link:

<a href="{{route('news.index', ['tag' => $tag])}}">{{$tag->name}}</a>

Controller

        if($request->has('tags')){
            $tag=Tag::where('name',$request->tags)->first();
            $news=$tag->news;
        }else{
            $news= News::paginate(15);
        }

searching for the name of the tag rather than the ID

Then change the link to send the name rather than the ID

@snapey The URL is now showing the tag name like this: http://localhost:8000/news?tags=entertainment with the posts associated with it.

But how can i make the url like this http://localhost:8000/news/entertainment and also display the posts associated with it.

@snapey this has come up before, in the route:

Route::get('/{tag?}', 'NewsController@index');

How do you initially get the {tag?} in there.

Meaning, many times the initial search is a post. After that, during paginating you use a get route.

Me, I just get the POST values in the request and build a redirect to the get route with the parameters. Works perfect.

    public function processAdmin()
    {
        if (!ChkAuth::chkRole('admin')) {   // ignore I have custom Auth
            return redirect('indexbl');
        }
        if(Request::has('submit')){
            $dogsearch = !empty(Request::input('psch')) ? Request::input('psch') : '';
            return redirect('dog/indexadmin/' . $dogsearch);
        }
    }

You have to somehow initially have the parameter to use.

Gives

somesite.com/dog/indexadmin/c?page=2

If "c" was the search string. But paginator is still query string.

Just saying many do not take into account an initial search for products as example is a post, not a get.

@jlrdw But The URL is now showing the tag name like this: http://localhost:8000/news?tags=entertainment with the posts associated with it.

But how can i make the url like this http://localhost:8000/news/entertainment and also display the posts associated with it.

I don't use tags. If I am searching for something or whatever I use field names.

$dogsch = $dogsearch . "%";

$query = Dog::where('dogname', 'like', $dogsch);
        if ($aval == "n") {
            $query->where('adopted', '=', 1);
        } else if ($aval == "y") {
            $query->where('adopted', '=', 0);
        }
        $dogs = $query->orderBy('lastedit', 'DESC')->paginate(5);

        $params = array('aval' => $aval);

Probably what snapey said for tags. I was just saying a search usually comes from a posted form, those parameters have to be converted to usable route parameters, route parameters don't just get there from nowhere.

Adopted above is a field name, dogname is a field name.

Edit: I wouldn't know how to do a search on a "tag".

But if speaking of friendly url, pagination and searching has to be taken into account. Most crud is derived from a search to start with.

@jlrdw I am not searching, i am just trying to make my menu navigation link be simple and clean instead of being like this http://localhost:8000/news?tags=entertainment

it should be like this http://localhost:8000/news/entertainment

Like I said use snapey answer, I know I over explain sometimes I was just trying to help you for future.

Just trying to say a get route has to be built up correctly.

I guess when I saw ?tags=1, the query string I figured you were searching.

ok, you want to accept as route parameter rather than query string, and you also want it to work for just /news/ (unfiltered)

web.php

Route::get('news/{tag?}', 'NewsController@index')->name('news.index');

Controller

    public function index(Request $request, $tag=null)
    {   
        if($tag)){
            $tag=Tag::find($tag);
            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

url

<a href="{{route('news.index', ['tag'=>$tag->name])}}">{{$tag->name}}</a>

I think thats it.

Main thing is optional tag in the URL and optional tag in the controller method

You also need to paginate on both paths so that the view can rely on getting paginated posts

I've also added the $tag into the view so that you can show what the current tag is

@snapey with this controller

public function index(Request $request, $tag=null)
    {   
        if($tag)){
            $tag=Tag::find($tag);
            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

I am getting error syntax error, unexpected ')'

But after trying this

public function index(Request $request, $tag=null)
    {   
        if($tag){
            $tag=Tag::find($tag);
            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

it takes me to http://localhost:8000/news/news i get 404 not found, the posts aren't there

Build the initial URL you need in a controller on first use only.

Redirect it to the route you have built that's exactly like you need.

Everything should now work perfect, either use a single controller and Skip if not first use or use two separate controllers choice is yours.

But somehow you have to initially build the URL you expect to match a route.

I've already given an example of a redirect.

Those route parameters have to come from somewhere they don't just get there by themselves.

No idea how are you are doing your very first page load.

Edit you have

    if($request->has('tags')){

How are you initially getting parameters in the request. You said you had no form you are submitting.

What if you just type the URL you want in the address bar?

http://localhost:8000/news/entertainment

@snapey Exactly i want my URL to be like this http://localhost:8000/news/entertainment but it is returning 404 not found instead.

But This

http://localhost:8000/news?tags=news is working

Sorry, the last example I posted reverted the earlier change. It should be looking for the name not using find

public function index(Request $request, $tag=null)
    {   
        if($tag){
            $tag=Tag::where('name',$tag)->first();
            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

@snapey So

Controller Would be like this

public function index(Request $request, $tag=null)
    {   
        if($tag){
            $tag=Tag::where('name',$tag)->first();
            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

web.php

Route::get('news/{tag?}', 'NewsController@index')->name('news.index');

link

<a href="{{route('news.index', ['tag'=>$tag->name])}}">{{$tag->name}}</a>

after trying this, the link is now http://localhost:8000/news/entertainment but i am getting 404 | Not Found no post under that tags appears

and http://localhost:8000/news ? Does that still work?

What do you get with dd() added as shown

public function index(Request $request, $tag=null)
    {   
        if($tag){
            $tag=Tag::where('name',$tag)->first();

            dd($tag);

            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

Is your tag named Entertainment or entertainment You have to use the same lettercase

@snapey the name is entertainment in my tags table in database

and this code below Still gives 404 on http://localhost:8000/news/entertainment

public function index(Request $request, $tag=null)
    {   
        if($tag){
            $tag=Tag::where('name',$tag)->first();

            dd($tag);

            $news=$tag->news()->paginate(15);
        }else{
            $news= News::paginate(15);
        }
        return view('categories.news',compact(['news','tag']));
    }

So its not hitting this code at all?

Do you have other /news routes in your web.php?

@snapey it is working now

initially i had another /news in my route which is

Route::resource('/news', 'NewsController');

But i have removed it and the pages load with respective posts

@snapey But news.create won't work after removing it if i want to create new posts

<div class="new-topic">
            <a href="{{route('news.create')}}">( Create New Topic )</a>
        </div>

Saying Route [news.create] not defined.

ok, so its not possible to share the same url

You could leave /news/ as a resource controller and come up with a new route for your index, for instance

Route::get('news/tagged/{tag?}', 'NewsController@index')->name('news.index');

put this route before your resource route

@snapey Everything works with the url http://localhost:8000/category/entertainment and http://localhost:8000/category/news

But in a single post i am trying to show the category associated with the post but it is giving Trying to get property 'name' of non-object

[{{$news->tags->name}}]

isn't this a new question?

You did not load the tag model when you fetched the news?

@snapey Post i make under the entertainment tag appears twice. How do i take care of this bug?

You sure its only in the database once?

@snapey it appears in the database twice.