Level 33
Do you have the set the right permissions on the map where the files are being stored? https://laracasts.com/discuss/channels/general-discussion/laravel-framework-file-permission-security
Nov 17, 2016
15
Level 3
File delete not actually deleting a file
I am trying to delete a file via Ajax post request:
public function ajaxDeleteImage(Request $request) {
if ($request->ajax()) {
$path = $request->input('imgUrl');
$id = $request->input('id');
$currency = Currency::findOrFail($id);
$currency->cur_icon = '';
\File::delete($path);
$currency->save();
return 'Deleted image!';
}
return \App::abort(404);
}
However file is not being delete, but path to the image are deleted successfully. What might the problem? Laravel 5.2
Level 3
@lars64 i have the right permissions.
Level 33
@heihachi88 try this:
Storage::delete($path);
Level 3
Same, nothing happens, file remains under public/uploads. Why everything is so damn hard in laravel lol. Simple tasks become impossible.
Tried now using php artisan tinker:
>>> File::delete('/uploads/dogecoin_ava-581d6b2231e9a.png');
PHP warning: unlink(/uploads/dogecoin_ava-581d6b2231e9a.png): No such file or directory in /srv/www/sc/vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php on line 156
Looks like it can't see the file, how come?
Level 33
@heihachi88 why not store it in storage? It's safer. In the public folder anybody can acces it.
And Laravel makes it a lot easier.
Level 53
As @lars64 mentioned, Laravel is setup for you to use storage for your files and run php artisan storage:link to mirror in your public folder. Also, when you utilize the local storage folder, Laravel stores the file in storage/app. Then to delete, you would Storage::disk('local')->delete('file.jpg');. If you can't see the file, make sure the visibility is set to "public". You can set it by Storage::setVisibility('file.jpg', 'public'); Or, you can check it by Storage::getVisibility('file.jpg');.
1 like
Level 1
@ejdelmonico in my case i tried in tinker
Storage::delete('storage/images/ndx9CXdHD1oqeQJLhmGeAqosLz6utzEUutIR3WIX.jpg');
= true
It was returning true but the file was still there untouched!
However when i tried to specify the disk, which was set to public, the image got deleted right away:
> Storage::disk('public')->delete('images/ndx9CXdHD1oqeQJLhmGeAqosLz6utzEUutIR3WIX.jpg');
= true
This time it is returning true but with a real result.
Level 15
What is in $path?
You need to pass the absolute path of the image to File. So if $path hold the relative path (public/uploads/image.png).
If that's the case you need:
\File::delete(base_path($path));
I wrote a bunch of words about this the other day: https://tenerant.com/blog/deleting-files-laravel-php/
Level 3
@ejdelmonico what's the case for Laravel 5.2?
ln -s storage/app/public public/storage
my $path var contains = /uploads/image.png. Uploads folder located in public folder.
Level 15
Then you would need:
\File::delete(public_path($path));
Forgot about the public_path() helper. At any rate, you need to use the absolute path.
2 likes
Level 53
@heihachi88 Did you check to make sure the visibility is public? If it is not, everything you try will fail.
1 like
Level 3
That worked, bro, thank you. I came from Laravel 4, tried to reuse my code, but that's not the case in L 5.2
Next project i will try to use Storage, looks like a convenient thing.
1 like
Level 15
@heihachi88 Cool! Someone suggested using the Storage facade instead. I think it's fine either way. Storage uses the 'local' disk by default and assumes your path is storage_path('app'). You'll also see a public disk with the default path storage_path('app/public') and the docs explain why storing your publicly accessible files here can be a good idea: https://laravel.com/docs/5.2/filesystem#configuration
The tl;dr is that you'll end up wishing you had done it that way to begin with if you start using Envoyer or something similar for deployments.
Level 3
What benefits of using Envoyer?
Level 15
@heihachi88 Zero downtime deployments in this case. Specifically, the way Envoyer deals with maintains the files in storage. Check out the link above: "The Public Disk" and see: https://laracasts.com/series/envoyer/episodes/2 as well as what was mentioned up thread about it.
You store everything created or uploaded on your server in storage/app/public and use php artisan storage:link to create a symbolic link from storage/app/public to public/storage. In fact, that would be a web hook you'd run during your deployment.
Envoyer takes the hassle out of managing the symlinking and rotating new deployments. Plus, you can fall back to a previous deployment with a click. If you are doing it manually, the $100/year is worth it for the time it saves you alone.
In terms of maintaining those files across deployments, the only way I see it working out is if you are just syncing over SSH or something. And, that's FINE if this is just a hobby or you're just getting started, but only crazy people do that with apps that make money for them or for the business for which they work.
Anyway, check it out. I use both Forge and Laravel at work. Love them both to pieces.
Please or to participate in this conversation.