Level 63
You are trying to get the length of some variable which is probably not countable.
var s = document.getElementById("slide").getElementsByTagName("img");
console.log(s);
What do you see in the console ?
Dec 4, 2022
3
Level 10
Uncaught TypeError: s[s.length] is undefined
HTML
<!DOCTYPE html>
<html>
<head>
<title>Slider</title>
</head>
<body>
<div id="slide">
<img src="0.jpg">
<img src="1.jpg">
<img src="2.jpg">
</div>
<script>
setInterval(function(){
slide()
},2000);
let index = 0;
function slide(){
var s = document.getElementById("slide").getElementsByTagName("img");
++index;
if(index == s.length) index = 0;
if(index == 0)
{
s[s.length].style.display ="none";
}
else
{
s[index-1].style.display ="none";
s[index].style.display ="inline";
}
}
</script>
</body>
</html>
Level 73
You will need to do length-1 as you are going out of bounds by trying to use s[3] which obviously does not exists.. use this:
if(index == 0)
{
s[s.length - 1].style.display="none";
}
2 likes
Level 63
@Nakov Oh I didn't notice that ;).
Please or to participate in this conversation.