collection check for existing IDs inside collection

@t0berius what if you simply try:

// this will return a collection of just IDs
$editableStockItemIds = $product->stockItems()->available()->pluck('id');

// and then
dd($editableStockItemIds->contains($request->stockItem)); 

Assuming that the stockItem from the request is a single ID not an array of IDs.

@nakov It's an array.

@t0berius

Would you dump($editableStockItemIds) and post the result so we can see exactly what we're looking at.

so $request->stockItem is an array of Ids from the form?

You want to check if ANY of these are in the available stock items?

OR you want to check that ALL of these are in the available stock items?

OR you want to check that NONE of these are in the available stock items?

One approach is to use the request ids in a whereIn eloquent query. The result you get back will be no records, some records but a different count, or exactly the same count. Use this depending on which of the above questions you want to answer

@snapey I want to make sure that ALL of these are in the available stock items. Some kind of "validation" for the IDs from the form, to make sure they all are part of the product itself (stockItems of the product).

So maybe as suggested. Count the IDs provided, query the database, count the result. If the counts are the same then your query of the database was an accurate match.

Could you not just use:

$editableStockItem = $product->stockItems()->available()->whereId($request->stockItem->id)->first();

To return it if it's available; or

$editableStockItem = $product->stockItems()->available()->whereId($request->stockItem->id)->exists();

to check its availability instead of getting a list of Ids and looping through them?

@snapey

I've used:

    //make sure all IDs from POST request are part of the stockItems which are available for the selected product
    abort_unless(collect($request->stockItem)->keys()->diff($editableStockItemIds)->isEmpty(), 404);

any thoughts against?

What is it you're trying to do?

Are you just checking whether the $request->stockItem is available by checking whether its Id is in the list of available products, or something else?

@geordiejackson I'm checking if the posted ids from form (array) are all in a collection (editableStockItemIds). This is a check to make sure, the ids of the items a user is trying to edit are somehow "related" to the users products.

You said It's an array. Why not use in_array.

https://www.php.net/manual/en/function.in-array.php

@t0berius

So $request->stockItem is not a single id but an array?

@jlrdw Yes, the form element from POST request is an array, the collection itself isn'it. @geordiejackson yes.

I would suggest renaming $request->stockItem to $request->stockItems - that's good programming practice.

Your idea of:

abort_unless(collect($request->stockItem)->keys()->diff($editableStockItemIds)->isEmpty(), 404);

Should work.

Turn $request->stockItem into a collection, do a loop, and each Loop see if it's part of $editableStockItemIds. I imagine using in.

Edit: Not in, but contains, I was thing sql at first -- sorry.

You have my suggestion...

Any problems with my approach (turning the request POST form into a collection and compare both collections using diff())?

not if implemented properly, but since you are doing a query anyway....

Hey, just my thoughts... maybe this quick one liner?

$editableStockItem = StockItems::with('product')->available()->where('product_id', $product->id)-> findOrFail($request->stockItem);

Just make sure to use findOrFail at the very end of your query.