What do you expect to happen with this Eloquent query?

Hi, This Eloquent query is designed to delete records from the connections table based on specific conditions.

The query is initialized on the connections table using Connection::query(). This starts a new query builder instance for the connections model.

Conditional Where Clauses: The where method is used to group two sets of conditions. This is done within a nested where clause using a closure (anonymous function).

First Set of Conditions: Inside the closure, the query checks for records where:

link_from_type equals $link_from_type link_from_id equals $link_from_id link_to_type equals $link_to_type link_to_id equals $link_to_id Or Conditions: The orWhere method is then used to specify an alternative set of conditions. This means that if the records do not match the first set of conditions, they will be checked against the following:

link_from_type equals $link_to_type link_from_id equals $link_to_id link_to_type equals $link_from_type link_to_id equals $link_from_id Delete Operation: After applying the conditions, the delete method is called to remove all records that match either of the two sets of conditions.

This query will delete records from the connections table where either: The combination of link_from_type, link_from_id, link_to_type, and link_to_id matches the specified values, or The combination of link_from_type, link_from_id, link_to_type, and link_to_id matches the values in reverse. In other words, it looks for records where the specified link configuration or its reversed counterpart matches and deletes those records.

That was the intention, but that is not what happens. @iamgeorge

That's nasty.

I knew it had to do with orWhere not using a closure. So I thought maybe missing parentheses.

That's not a behavior I would've guessed.

At first look I see no issues. However, after your comment that there's a trap. I investigated the issue 😀

The problem is with orWhere.

First where is doing what is expected which is

(
	link_from_type' = $link_from_type
	AND
	link_from_id =  $link_from_id
	AND
	link_to_type = $link_to_type
	AND
	link_to_id = $link_to_id
)

However the orWhere is using OR in the combined condition instead of AND

(
	link_from_type' = $link_from_type
	OR
	link_from_id =  $link_from_id
	OR
	link_to_type = $link_to_type
	OR
	link_to_id = $link_to_id
)

Usually in conditions like this, I always use callback to combine conditions instead of passing them as an array.

Connection::query()
            ->where(function(Builder $q) use($link_from_type, $link_from_id, $link_to_type, $link_to_id){
       $q->where([
             'link_from_type' => $link_from_type,
             'link_from_id' => $link_from_id,
             'link_to_type' => $link_to_type,
             'link_to_id' => $link_to_id,
      ]);
})
->orWhere(function(Builder $q) 
use($link_from_type, $link_from_id, $link_to_type, $link_to_id){
     $q->where([
         'link_from_type' => $link_to_type,
         'link_from_id' => $link_to_id,
         'link_to_type' => $link_from_type,
         'link_to_id' => $link_from_id,
      ]);
  })
->delete();

I think this will delete exactly record.