How to make efficient query for $post->commnets and comment->user

Hello, I have a Post model which hasMany Commnets and every comment has one User. If I run this blade code

@foreach( $post->comments as $comment )
      <div>{{ $comment->text }} <br><small>{{ $comment->user->name }}</small></div>
@endforeach

it makes one separate query for user in every loop of the foreach cycle.

I know about Post::with() but this is the third level of relations. Is it possible to have only one query for all users which wrote comments?

Controller code looks like

public function detail(Post $post)
{
	return view('home.detail')->with([
		'post' => $post
	]);
}

MichalOravec

5 years ago

Best Answer

Level 75

Use lazy eager loading

public function detail(Post $post)
{
    $post->load('comments.user');

    return view('home.detail', compact('post'));
}

public function detail($id)
{
    $post = Post::with('comments.user')->findOrFail($id);

    return view('home.detail', compact('post'));
}

Docs: https://laravel.com/docs/7.x/eloquent-relationships#lazy-eager-loading

1 like

squiaios

5 years ago

Level 1

Your $post variable is already loaded, so if you can use the load method

public function detail(Post $post)
{
        $post->load(['comments', 'comments.user']);

	return view('home.detail')->with([
		'post' => $post
	]);
}

1 like

Čamo

5 years ago

Level 3

This is it. Thank you Mišo.

1 like

Čamo

5 years ago

Level 3

@squiaios @michaloravec wrote it first. Thank you for help.

Please or to participate in this conversation.