How can I save multiple checkbox inputs in a single request

Level 67

$days = $request->day;
$froms = $request->from;
$tos = $request->to;

foreach ($days as $key => $day) {
    Thing::create([
        'day' => $day,
        'from' => $froms[$key],
        'to' => $tos[$key],
    ]);
}

Your question also mentions checkboxes, but I don't see anything related to checkboxes here?

Edit: it looks like these are all for the same property, so just do

<form method="post" action="{{route('viewing.store')}}">
    @csrf
    <input type="hidden" name="property_id" value="{{$property->id}}">

and remove all of the other hidden property_id fields. They are not doing anything.

Level 5

I just tried that:

public function store(Request $request)
{

    $days = $request->days;
    $froms = $request->from;
    $tos = $request->to;

    foreach ($days as $key => $day) {
        Viewingdate::create([
            'property_id' => $request->property_id,
            'day' => $day,
            'from' => $froms[$key],
            'to' => $tos[$key],
        ]);
    }
}

But it gives me an invalid argument error

Invalid argument supplied for foreach()

Level 67

Ah, the problem is the days are checkboxes. In html forms, checkboxes only get submitted if they are checked, so that's throwing it off.

Level 67

This will work.

Change your inputs to this:

<div class="flddex">
        <label class="day">Tuesday</label>
        <input type="checkbox" name="day[Tue]" value="Tue">
        <label>From</label>
        <input type="text" class="timepicker form-cont" name="from[Tue]"></input>
        <label>To</label>
        <input type="text" class="timepicker form-cont" name="to[Tue]"></input>
    </div>

Notice the name attributes now use the day name as the array key in the inputs day[Tue], from[Tue] and to[Tue]. So you'd do that to all of the other day sections as well (using the correct day, obviously)

and in the controller

        $days = $request->day;
        $froms = $request->from;
        $tos = $request->to;

        if (count($days)) {
            foreach ($days as $key => $day) {
                Viewingdate::create([
                    'property_id' => $request->property_id,
                    'day' => $day,
                    'from' => $froms[$key],
                    'to' => $tos[$key],
                ]);
            }
        }

Level 5

So in this case I have to save one row at the time.

I try doing that, but when I return a $request I can only get the day, and not the from and to.

{"_token":"rnKBPQJrJk8K5MlwNIe9tGdVHOQ7MzcWkEci2xmo","property_id":"21","from":null,"to":null,"day":"Thu"}

I replaced

<input type="text" class="timepicker form-cont" name="from[]"></input>

for this:

But it didnt make a difference in the error.

Level 67

You could save a bit of code as well, since these are all basically the same thing repeated over and over.

In the controller,

$days = [
    'Monday' => 'Mon',
    'Tuesday' => 'Tue',
    // etc
];

Then pass $days to your view in addition to property, and in the view, generate the form.

<form method="post" action="{{route('viewing.store')}}">
    @csrf
    <input type="hidden" name="property_id" value="{{$property->id}}">

    @foreach ($days as $dayName => $dayAbbr)
    <div class="flddex">
        <label class="day">{{ $dayName }}</label>       
        <input type="checkbox" name="day[{{ $dayAbbr }}]" value="{{ $dayAbbr }}">
        <label>From</label>
        <input type="text" class="timepicker form-cont" name="from[{{ $dayAbbr }}]"></input>
        <label>To</label>
        <input type="text" class="timepicker form-cont" name="to[{{ $dayAbbr }}]"></input>                
    </div>
    @endforeach

    <button type="submit" class="btn1-primary btn1">Add</button>
</form>

Level 67

So in this case I have to save one row at the time.

I try doing that, but when I return a $request I can only get the day, and not the from and to.

Did you do what I said in the post just before you posted that? I tested it, and it works.

<div class="flddex">
        <label class="day">Tuesday</label>
        <input type="checkbox" name="day[Tue]" value="Tue">
        <label>From</label>
        <input type="text" class="timepicker form-cont" name="from[Tue]"></input>
        <label>To</label>
        <input type="text" class="timepicker form-cont" name="to[Tue]"></input>
    </div>

etc. Please reread that post.

Level 5

Sorry I didnt notice the previous answer. And yes you are right:

<form method="post" action="{{route('viewing.store')}}">
    @csrf
    <input type="hidden" name="property_id" value="{{$property->id}}">

    @foreach ($days as $dayName => $dayAbbr)
    <div class="flddex">
        <label class="day">{{ $dayName }}</label>       
        <input type="checkbox" name="day[{{ $dayAbbr }}]" value="{{ $dayAbbr }}">
        <label>From</label>
        <input type="text" class="timepicker form-cont" name="from[{{ $dayAbbr }}]"></input>
        <label>To</label>
        <input type="text" class="timepicker form-cont" name="to[{{ $dayAbbr }}]"></input>                
    </div>
    @endforeach

    <button type="submit" class="btn1-primary btn1">Add</button>
</form>

In the controller:

    $days = $request->day;
    $froms = $request->from;
    $tos = $request->to;

    if (count($days)) {
        foreach ($days as $key => $day) {
            Viewingdate::create([
                'property_id' => $request->property_id,
                'day' => $day,
                'from' => $froms[$key],
                'to' => $tos[$key],
            ]);
        }
    }

It saves one record at the time. If I try select multiple rows then it gives integrity contraint error:

SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'from_time' cannot be null (SQL: insert into `viewingdates` (`property_id`, `day`, `from_time`, `to_time`, `updated_at`, `created_at`) values (21, Tue, , , 2018-09-26 20:17:26, 2018-09-26 20:17:26))

Level 67

Well, it looks like you're saving them under different field names than they actually are!

Looks like in the db, the columns are actually named from_time and to_time, but when you're saving them here

            Viewingdate::create([
                'property_id' => $request->property_id,
                'day' => $day,
                'from' => $froms[$key],
                'to' => $tos[$key],
            ]);

you're using from and to. Change those to from_time and to_time

Level 5

Not really the case and yes I made it a little confusing with the names. but I have it saved as from_time and to_time

if (count($days)) {
    foreach ($days as $key => $day) {
        Viewingdate::create([
            'property_id' => $request->property_id,
            'day' => $day,
            'from_time' => $froms[$key],
            'to_time' => $tos[$key],
        ]);
    }
}

If I choose one day and times it works. But if I try to select many days and times it gives the integrity constraint

Level 67

Then I suspect something is not working properly with your timepicker script.

If you do dd($request->all()); in the controller method as the first thing, do you see values coming through for the from/to times? If not, something is wrong with your form and they're not being submitted properly in the request. I think we're onto a totally different problem now.