Level 55
@karagiannidis they do different. First one check id column of assets table, second one - asset_id column
Aug 22, 2022
6
Level 3
eloquent whereHas query variation
Hello everyone,
These 2 snippets below seem to achieve the same thing. Which one do you think has the proper syntax and why?
1:
$user = User::whereHas('assets', function ($query) {
$query->where('assets.id', request()->query('asset_id'));
})->first();
2:
$user = User::whereHas('assets', function ($query) {
$query->where('asset_id', request()->query('asset_id'));
})->first();
Level 102
Is the asset_id on the users table? If so, why do you need the whereHas() ?
$user = User::where('asset_id', request()->query('asset_id'))->first();
Level 3
@Sinnbeck Thanks for your answer. No, it's a many-to-many relation.
@silencebringer Thanks for your answer. So, if I understood correctly, the first one checks the assets table and the second one checks the pivot table? So it makes more sense to use the second one!?
Level 102
@Karagiannidis Ah ok :) Why not check the queries to compare them? :) You can see it using something like debugbar
Level 3
@Sinnbeck Thanks, checked it with debugbar and they are indeed different as silencebringer explained. Also, the second one is more performant.
Level 102
@Karagiannidis Exelent. And if they give exactly the same result (I expect they will), then you have your answer :)
Please or to participate in this conversation.