Eloquent update with 'where' updates all rows in database

@tykus

if($this->pay($id)) {
            $level = BuildingUser::where('user_id', Auth::user()->id)->where('building_id',$id)->first();
            $level->update(['level' =>  $level->level + 1]);
            //$this->addResourceGain($id);
            return redirect()->route('palace');
        }
        else {
            return redirect()->back()->with('failure2', 'You do not have the required resources to upgrade this building.');   
        }

 public function pay($id) {
        $cost = Building::where('id', $id)->first(['cost_gold','cost_wood','cost_stone','cost_sand','cost_copper','cost_tin','cost_iron','cost_silver','cost_bronze','cost_steel','cost_glass','cost_mithril']);
        $resources = Resource::where('user_id', Auth::user()->id)->first(['gold','wood','stone','sand','copper','tin','iron','silver','bronze','steel','glass','mithril']);
        $costArray = $cost->toArray();
        $level =  BuildingUser::where('user_id', Auth::user()->id)->where('building_id',$id)->first();

        $costNotNull = array_filter($costArray);
        $resourceName = array_keys($costNotNull);
        $true = 0;
        
        //check if user can afford
        foreach($resourceName as $resource) {
            $resourceKey = str_replace("cost_","",$resource);

            if(($resources->$resourceKey - ($cost->$resource*5*$level->level)) >= 0) {
                $true++;  
            }
        }
        
        //deduct resources now that we know the user can afford it all
        if(count($resourceName) === $true) {
            foreach($resourceName as $resource) {
                $resourceKey = str_replace("cost_","",$resource);
                $resources->$resourceKey = $resources->$resourceKey - ($cost->$resource*5*$level->level);
                $resources->save();
            }
            return true;
        }
        else {
            return false;
        }      
    } 

@oronatur very strange that the entire table should be updating; what do you get if you dd($level) after retrieving it?

As an alternative, you try increment:

if($this->pay($id)) {
  $level = BuildingUser::where('user_id', Auth::id())->where('building_id',$id)->increment('level');
    return redirect()->route('palace');
}
return redirect()->back()->with('failure2', 'You do not have the required resources to upgrade this building.');   

@tykus Yeah, I thought so too. dd of level:

App\Models\BuildingUser {#1598 ▼ // app/Http/Controllers/BuildingController.php:34
  #connection: "mysql"
  #table: "building_user"
  #primaryKey: null
  #keyType: "int"
  +incrementing: false
  #with: []
  #withCount: []
  +preventsLazyLoading: false
  #perPage: 15
  +exists: true
  +wasRecentlyCreated: false
  #escapeWhenCastingToString: false
  #attributes: array:3 [▼
    "user_id" => 8
    "building_id" => 1
    "level" => 9
  ]
  #original: array:3 [▼
    "user_id" => 8
    "building_id" => 1
    "level" => 9
  ]
  #changes: []
  #casts: []
  #classCastCache: []
  #attributeCastCache: []
  #dates: []
  #dateFormat: null
  #appends: []
  #dispatchesEvents: []
  #observables: []
  #relations: []
  #touches: []
  +timestamps: false
  #hidden: []
  #visible: []
  #fillable: array:3 [▼
    0 => "user_id"
    1 => "building_id"
    2 => "level"
  ]
  #guarded: array:1 [▼
    0 => "*"
  ]
}

Edit: Increment works, so thanks for that! I still wonder what was/is going on though.

@oronatur there is no ID or primary key

@tykus No, it's a pivot table

@oronatur yeah, but that's why the update was failing to constrain itself.