Level 75
In controller you have topbar instead of topbars.
1 like
Dec 19, 2022
9
Level 41
Undefined variable $topbars
Kindly help :-
namespace App\Http\Controllers\Frontend;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\Models\Topbar;
class TopbarController extends Controller
{
/**
* Display a listing of the resource.
*
* @return \Illuminate\Http\Response
*/
public function index()
{
$topbar = Topbar::latest()->get();
return view ('partial.topbar', compact('topbar'));
}
/**
* Show the form for creating a new resource.
*
* @return \Illuminate\Http\Response
*/
public function create()
{
//
}
/**
* Store a newly created resource in storage.
*
* @param \Illuminate\Http\Request $request
* @return \Illuminate\Http\Response
*/
public function store(Request $request)
{
//
}
/**
* Display the specified resource.
*
* @param int $id
* @return \Illuminate\Http\Response
*/
public function show(Topbar $topbar)
{
$topbar = Topbar::latest()->get();
return view ('partial.topbar', compact('topbar'));
}
/**
* Show the form for editing the specified resource.
*
* @param int $id
* @return \Illuminate\Http\Response
*/
public function edit($id)
{
//
}
/**
* Update the specified resource in storage.
*
* @param \Illuminate\Http\Request $request
* @param int $id
* @return \Illuminate\Http\Response
*/
public function update(Request $request, $id)
{
//
}
/**
* Remove the specified resource from storage.
*
* @param int $id
* @return \Illuminate\Http\Response
*/
public function destroy($id)
{
//
}
}
<!--Header Top-->
<div class="header-top">
<div class="auto-container clearfix">
<div class="top-left clearfix">
<ul class="list">
@foreach($topbars as $topbar)
<li><span class="icon fas fa-envelope"></span> {{ $topbar->phone }} </li>
<li><span class="icon fas fa-phone"></span> <a href="tel:+555–123–2323"> {{ $topbar->address }}</a></li>
</ul>
</div>
<div class="top-right clearfix">
<ul class="social-icons">
<li><a href=" {{ $topbar->facebook }}"><span class="fab fa-facebook-f"></span></a></li>
<li><a href="{{ $topbar->google }}"><span class="fab fa-google"></span></a></li>
<li><a href="{{ $topbar->twitter }}"><span class="fab fa-twitter"></span></a></li>
<li><a href="{{ $topbar->skype }}"><span class="fab fa-skype"></span></a></li>
<li><a href="{{ $topbar->linkedin }}"><span class="fab fa-linkedin"></span></a></li>
@endforeach
</ul>
</div>
</div>
</div>
<!-- End Header Top -->
Route::get('/', [Frontend\TopbarController::class, 'show'])->name('partial.topbar');
why am I getting this error
Level 41
@MichalOravec the same issue
1 like
Level 102
@Michael Fayez can you show the updated controller?
1 like
Level 41
<?php
namespace App\Http\Controllers\Frontend;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\Models\Topbar;
class TopbarController extends Controller
{
/**
* Display a listing of the resource.
*
* @return \Illuminate\Http\Response
*/
public function index()
{
$topbars = Topbar::latest()->get();
return view ('partial.topbar', compact('topbar'));
}
/**
* Show the form for creating a new resource.
*
* @return \Illuminate\Http\Response
*/
public function create()
{
//
}
/**
* Store a newly created resource in storage.
*
* @param \Illuminate\Http\Request $request
* @return \Illuminate\Http\Response
*/
public function store(Request $request)
{
//
}
/**
* Display the specified resource.
*
* @param int $id
* @return \Illuminate\Http\Response
*/
public function show(Topbar $topbar)
{
$topbars = Topbar::latest()->get();
return view ('partial.topbar', compact('topbar'));
}
/**
* Show the form for editing the specified resource.
*
* @param int $id
* @return \Illuminate\Http\Response
*/
public function edit($id)
{
//
}
/**
* Update the specified resource in storage.
*
* @param \Illuminate\Http\Request $request
* @param int $id
* @return \Illuminate\Http\Response
*/
public function update(Request $request, $id)
{
//
}
/**
* Remove the specified resource from storage.
*
* @param int $id
* @return \Illuminate\Http\Response
*/
public function destroy($id)
{
//
}
}
1 like
Level 75
@Michael Fayez You have to change a parameter in compact as well.
compact('topbars')
1 like
Level 41
@MichalOravec the same problem
1 like
Level 63
@Michael Fayez
public function show(Topbar $topbar)
{
$topbars = Topbar::latest()->get(); // $topbars with an s
return view ('partial.topbar', compact('topbars')); // topbars with an s
}
But it's not logical because you display one topbar via the show method. And in your view it looks like you intend to show several topbars.
Are you sure that the blade code you are showing is really the partial.topbar view ?
Level 41
@vincent15000 I've solved the issue
class FrontendController extends Controller
{
public function index()
{
$topbars = Topbar::latest()->get();
return view('welcome', compact('topbars',));
}
Route::get('/', [Frontend\FrontendController::class, 'index'])->name('welcome');
1 like
Level 102
@Michael Fayez so what did you change differently than @michaloravec and @vincent15000 suggested?
1 like
Please or to participate in this conversation.