Validation of belongsToMany

@Snapey

It does appear I'm getting an empty array.

so with prepareForValidation method to take the RAW content and add it $this as data :

curl --location --request POST 'http://connect.lndo.site/api/custom_forms/crud/ewew/relationships/items' \
--header 'Content-Type: application/json' \
--data-raw '[]'

within my request:

    public function rules(): array
    {
       dump($this->data);

        return [
            'data.*' => 'array',
            'data.*.type' => 'required|string',
            'data.*.id' => 'required|string'
        ];
    }

    protected function prepareForValidation()
    {
        $this->merge([
            'id' => $this->route('id'),
            'data' => $this->getContent()
        ]);
    }

The dump does return [] but its still not failing validation.

with the following:

curl --location --request POST 'http://connect.lndo.site/api/custom_forms/crud/ewew/relationships/items' \
--header 'Content-Type: application/json' \
--data-raw '[
    {
        "id": "cb3b8781-a911-61ec-1b91-9c7619f2b19d"
    }
]'

its should fail because I've removed type key from object.

I think its still passing data as a string for when it gets to the controller, as I've got to do:

    $data = json_decode($request->except('id')['data']);

before I can do anything with the data.

any ideas?

@automica

** no attributes name

https://example.com/[item]=1

    public function rules(): array
    {
       dump($this->validationData()); // empty
    }

this make sense, because Laravel can't try to guess the attributes name for you or some security reason

    protected function prepareForValidation()
    {
        $data = $this->getContent();
        
        // format the body content to meet the validation structure
        $data = array(......);
        
        $this->merge([
            'data' => $data,
        ]);
    }

@newbie360 thanks. I'm creeping closer...

with

curl --location --request POST 'http://connect.lndo.site/api/custom_forms/crud/ewew/relationships/items' \
--header 'Content-Type: application/json' \
--data-raw '[
    {
        "id": "cb3b8781-a911-61ec-1b91-9c7619f2b19d"
    }
]'

and:

    public function rules(): array
    {
        dump($this->validationData()['data']);

        return [
            'data.*.type' => 'required|string|size:5',
            'data.*.id' => 'required|string|size:36'
        ];
    }

    protected function prepareForValidation()
    {
        $data = collect(json_decode($this->getContent()));

        $this->merge([
            'id' => $this->route('id'),
            'data' => $data->map(function ($row) {
                return (array)$row;
            })
        ]);
    }

I can see the data in the dump

Illuminate\Support\Collection {#1316
  #items: array:1 [
    0 => array:1 [
      "id" => "cb3b8781-a911-61ec-1b91-9c7619f2b19d"
    ]
  ]
}

but its still failing to validate the parts of this array.

@automica length:5 should be size:5 ?

@newbie360 thanks for that spot buts not responding to anything I put in rules.

edit, if I change the 'id' to 'idx' then I get a validation error.

  public function rules(): array
    {
        return [
            'idx' => 'required',
            'data.*.type' => 'required|string|size:5',
            'data.*.id' => 'required|string|size:36'
        ];
    }

    protected function prepareForValidation()
    {
        $data = collect(json_decode($this->getContent()));

        $this->merge([
            'id' => $this->route('id'),
            'data' => $data->map(function ($row) {
                return (array)$row;
            })
        ]);
    }

so it appears my issue is with

            'data.*.type' => 'required|string|size:5',
            'data.*.id' => 'required|string|size:36'

to check array keys.

The above looks like it should work out of the box, but for now I can do:

    public function rules(): array
    {
        $rules = ['id' => 'required'];

        foreach ($this->data as $index => $data) {
            $rules['data.' . $index . '.type'] = 'required|string|size:5';
            $rules['data.' . $index . '.id'] = 'required|string|size:36';
        }
        
        return $rules;
    }

@automica

weird, look the data structure is correct, and there just use string key, can you try add one rule

        return [
            //'idx' => 'required',
            'data' => 'array',
            'data.*.type' => 'required|string|size:5',
            'data.*.id' => 'required|string|size:36'
        ];

@newbie360

with

      return [
            'data' => 'array',
            'data.*.type' => 'required|string|size:5',
            'data.*.id' => 'required|string|size:36'
        ];

all my validation fails. it appears 'data' => 'array', is the culprit

but if I hard code 0 instead of *

        $rules = [
            'id' => 'required',
            'data.0.type' => 'required|string|size:5',
            'data.0.id' => 'required|string|size:36'
        ];

then all my validation works.

@automica

can you dump($this->data) with id and type

after that use this rule only

        return [
            'data.*.type' => 'required|string|size:5',
            'data.*.id' => 'required|string|size:36'
        ];

and add a method in the form request

    public function withValidator($validator)
    {
        $validator->setImplicitAttributesFormatter(function ($attribute) {
            [$field, $key, $value] = explode('.', $attribute);

            if ($field == 'data') {
                return sprintf('data error element:%d value:%s', $key +1, $value);
            }
        });
    }

any response ?

@newbie360 I've done that but I'm back to where I am earlier when its ignoring the rules with * in them.

interestingly, adding a dump inside the closure doesn't return any result which suggests setImplicitAttributesFormatter isn't being triggered.

    /**
     * Configure the validator instance.
     *
     * @param \Illuminate\Validation\Validator $validator
     * @return void
     */
    public function withValidator(\Illuminate\Validation\Validator $validator)
    {
        $validator->setImplicitAttributesFormatter(function ($attribute) {
		
	dump($attribute); 
            
            [$field, $key, $value] = explode('.', $attribute);

            if ($field == 'data') {
                return sprintf('data error element:%d value:%s', $key +1, $value);
            }
        });
    }

BTW i'm in laravel 7, and a rather worked version of it (existing client project), so I'm prepared to think there could be some oddness elsewhere in my environment.

would be good to know though.