Has Many Through Relationship changes foreign key

Show some code, how have you set up the relationship and how are you accessing it?

Sure!

Here's the relevant section of my User model:

    public function bookings() {
        return $this->hasMany('App\Booking');
    }
    public function requests() {
        return $this->hasManyThrough('App\Booking', 'App\Space');
    }

Here's my Space model:

  public function bookings()
  {
    return $this->hasMany('App\Booking');
  }

And finally my Booking model:

    public function space () {
        return $this->belongsTo('App\Space');
    }

    public function user () {
        return $this->belongsTo('App\User');
    }

Now, in my Controller, I try to access the requests like this:

$requests = Auth::user()->requests;

And now, every user_id in ´$requests` is equal to theAuth::user()->id`.

I can see that this query is run:

select "bookings".*, "spaces"."user_id" from "bookings" inner join "spaces" on "spaces"."id" = "bookings"."space_id" where "spaces"."user_id" = '1'

Maybe spaces.user_id simply overwrites to bookings.user_id?

I didn't go through the entire code, but for the last part

$requests = Auth::user()->requests; // Yes this will show request only for specific user in this case Auth::user()

To access all request for all users, you could load it like

$users = User::all()->with('request');
foreach($users as $user) {

    $requests = $user-> requests

}

Thank you very much for your answer. Unfortunately, it doesn't really solve my problem:

Basically, every Booking (or request, depending on from which side you're looking at it), is linked to two users: The user who made the booking, and the user who owns the space that has been booked.

This means that if I do $request->user, I wish to see the user who made the request, and not the one who owns the space. It also means that $Auth::user()->id should not equal $Auth::user()->requests->first()->user_id (that's why I have a hasManyThrough relationship and not a simple HasOne).

I hope that makes sense? :-)

I was now able to "fix" the error.

As I suspected, the MySQL query run by Laravel overwrote the user_id of the bookings table with the user_id of the spaces table.

I could solve the issue, by renaming user_id in bookings to renter_id.

Interestingly, there's now both a user_id and a renter_id on the collection models returned by the hasManyThroughrelationship, which is a bit unfortunate.

I just ran into the same issue, isn't this a bug in Laravel which should be reported? I think it's related to this issue: https://github.com/laravel/framework/issues/5389