Clean up large controller method

Sounds like you could be dispatching a few jobs on the queue to take care of the heavy lifting.

For example make a job called GeneratePdf. Your controller can dispatch that and move on to getting back to the user. You move all of that logic out of your controller and now you can dispatch that job from other parts of your code. :)

Gotcha! Yea I was thinking that for the PDF generation and then I will fire an event to handle all the notification stuff.

I get a little confused on some of the simpler stuff. Like calculating discounts. Should that go on the order model or create helper functions for that?

Just trying to organize my logic properly.

Thanks for your feedback!

To me it depends on how complex your discounting logic is. If it is simple, leave in on the order model and have an applyDiscount method where you for example pass in a coupon code that gets checked for a discount amount. If it is complex and will grow more complex in the future you could separate it out into its own class called Discount and handle the logic there. Hard to say without seeing more. I would not create helper methods in a separate file, I'd make a dedicated class if it wasn't going to be in the order model.

@wkinne validation: Use ValidateRequest Trait or for more freedom use form request (https://laravel.com/docs/5.6/validation#form-request-validation).

$this->validate($request,$rule)

creating or get customer: send the validated data to customer model and create or get. most likely get all item from here itself.

Customer::register($request)

Model Customer

public function register{
    static::firstOrCreate($request)
}

calculation and payment getway: create different method in the controller and move the code there for calculation and payment gateway return payment gateway response to post method. U can create method or can create class subscription

$this->subscription($request);

public function subscription{
    calculate and send the pay money to payment gateway and return to controller. 
}

PDF This is same as subscription can create method or class PDF

$this->registerpdf($request);

public function registerpdf{
    PDF::create or something ur code
}

Totally would be like..

Class Register

public function post {
    $this->validate($request,$rule);

    Customer::register($request);

    $payGateRes = $this->subscription($request);

    if(! $payGateRes) {
        return false or error msg
    }
    
    $pdfRes = $this->registerpdf($request);
    
    if(! $pdfRes) {
        return false or error msg
    }

    return true or success msg
}