testing error in laravel..

Level 102

Are you sure your database is reset after each test?

Level 21

@Sinnbeck not i don't used refeshDatasase !

Level 74

Check your Project factory, you need to pass the signed in user id to make the project belong to the created user.

Level 21

@Tray2 its done sir !

Level 74

@Shivamyadav Did it solve the issue?

Level 21

@Tray2 here it is , but it does not solve the issue

'owner_id' => function () {
                return User::factory()->create()->id;

Level 74

@Shivamyadav remove that owner_id

And pass it in your test instead.

	 $this->signIn();    
      $project = Project::factory()->create( [
		'owner_id' => Auth:user()->id
]);

Level 104

@tray2 the test is to prove the only the owner can change the Task; so it should not belong to the authenticated user.

@shivamyadav it is worth being explicit in your test - set up the world explicitly rather than implicitly, e.g.

public function test_only_the_owner_of_a_project_may_update_a_task()
{
    $user1 = User::factory()->create();
    $user2 = User::factory()->create();
    
    $project = Project::factory()->create(['owner_id' => $user1->id]);
    $task = $project->addTask('test tasks');
        
    $this->actingAs($user2)
        ->post($project->path() .'/tasks/' . $task->id, ['body' => 'changed'])
        ->assertStatus(403);
    $this->assertDatabaseMissing('tasks', ['body'=> 'changed' ]);        
}

Level 74

@tykus Ah, my bad, thought it the other way around. Didn't read properly.

Level 21

@tykus but i have passed it in the controller method as jeffreyWay sir in this episode https://laracasts.com/series/build-a-laravel-app-with-tdd/episodes/14 video time from 11:30

controller


    public function update(Project $project, Task $task)
    {
        if(auth()->user() != $project->owner)
        {
            abort(403);
        }
        
        $task->update([
            'body' => request('body'),
            'completed' => request()->has('completed')
        ]);
        return redirect($project->path());
    }

Level 21

@tykus or sir you can see that episode code of jeffreyway sir gitub is here https://github.com/laracasts/birdboard/commit/10c753148feec2430ecd2d2177c64d361cc3d343#diff-144cc7ccf135e444c6c0706667228cc25b553bb54bf2e173f009447df01ddd21 file ProjectTasksTest from line 35 and controller ProjectTasksController upadte method

Level 21

@tykus tried your suggested code also sir but getting same error😔

Level 104

@Shivamyadav why are you making a POST request to an update endpoint? Use put or patch instead:

$this->actingAs($user2)
    ->patch($project->path() .'/tasks/' . $task->id, ['body' => 'changed'])
    ->assertStatus(403);

Level 21

@tykus patch is not working sir , bcz i have used post method simply to update it ! By the way i have solved my issue , thank you sir for you give your precious time ❤️

Level 104

@Shivamyadav you defined a POST route for an update endpoint?

Level 21

@tykus yea sir! Everything working fine

Level 104

@Shivamyadav it might help if you stick with conventions

1 like