Debugbar Shows over 300 queries

What are the duplicated queries?

do you have view composers?

btw as you are not actually passing the user to the view, just eager loading relations, you could do this with just

    auth()->user()->load('following','categories');

@Snapey Yep, sure do have view composers, and that's definitely what's causing the issue. Not sure how to fix though.

What I'm doing is just gathering information about the user's account, such as followers, who they blocked, etc.

Here's one of the things I'm doing in my View Controller which is causing so many queries.

In the view composer

public function compose(View $view)
{
    $view->with('access', User::getAccess());
    ...

In User

public static function getAccess()
    {
        if (auth()->guest()) {
            return [];
        }

        $collection = new \Illuminate\Database\Eloquent\Collection();
        $collection->memberships = auth()->user()->memberships()->where('rebill_attempts', null)->pluck('price');
        $collection->purchased = auth()->user()->purchased()->pluck('post_id');

        return $collection;
    }

Also, thanks for the eager loading tip, that's awesome!

EDIT

So after some investigating, I believe this is the culprit in my GlobalServiceProvider

public function boot(ViewFactory $view)
    {
        $view->composer('*', \App\Http\ViewComposers\GlobalComposer::class);
    }

not sure how to fix this though.

you need to replace the * with the names of the views that need the shared data. otherwise the composer is run for every included view.

Yeah, that's actually what I mean when I said "not sure how to fix this." I knew that's what I should do, but not sure how. Sorry for my bad communication skills.

I'm reading the docs, but it's just not clicking for me. Where do I get the names of the views? if I have views/app.blade.php would app be the view name?

$view->composer('app', \App\Http\ViewComposers\GlobalComposer::class);

I tried that but it didn't work. That information basically need to be available everywhere, so I was receiving errors.

This didn't work either.

$view->composer('layouts.app', \App\Http\ViewComposers\GlobalComposer::class);

I've thought about storing all of this data in Redis but can't figure out how to get the user's information after login.

Here's what I ended up doing. I added the information to a session after the user logged in, and then accessed that session in the view composer, which greatly reduced my queries.

protected function sendLoginResponse(Request $request)
{
    $request->session()->regenerate();

    $request->session()->put('access', \App\User::getAccess());
    $request->session()->put('blocking', \App\User::getBlocking());
    $request->session()->put('followers', \App\User::getFollowers());
    $request->session()->put('following', \App\User::getFollowing());

    $this->clearLoginAttempts($request);
    return $this->authenticated($request, $this->guard()->user())
            ?: redirect()->intended($this->redirectPath());
}

is there a drawback to storing collections in a session? Or should I port this over to Redis?

Hi The problem I have found with the view composers and * that is not immediately obvious i that if you have a partial in a loop then the composer is called for each inclusion (like an n+1 problem for views)

the view composer can take an array of strings, with the string being the same as you would use in a controller to specify the view;

$view->composer(['posts.index', 'posts.edit', 'posts.create'], \App\Http\ViewComposers\GlobalComposer::class);

if all those extended resources/views/layouts/master.blade.php then you can just mention the master layout and all those that extend it will have access to the variables.

$view->composer('layouts.master', \App\Http\ViewComposers\GlobalComposer::class);

Unfortunately, it's much more complex than that, so I ended up creating a bunch of functions in a helper file and moving them into that. I'm still running more queries than I want, but it's much, much better than before, and will go a long way in helping me break this down further and figure out a better solution.

Thanks for your help!

Wouldn't caching the queries help ?

@ederson Not really, because the information gathered has to be up-to-date.

For instance, if a user follows someone, and the query is cached, they may refresh the page and it would look like they're not following that person, so they might keep hitting the follow button thinking something is wrong.

Edit: I am, however, looking into storing the query results in Redis, and updating that each time a user makes a change.

My idea was that you could cache it for a few seconds so they won't be repeated in the same request ...

I had a similar problem and caching solved but maybe your data change faster