Weird bug: curly braces on back

Anyone?

My new discovery is that it is happening because one of my Middlewares. I wrote AjaxJson middleware to translate all Ajax requests to JSON response. Weirdly, when I go back in history, Google Chrome makes this request Ajax. It contains this header:

X-Requested-With: XMLHttpRequest

And therefore $request->ajax() returns true.

This is my middleware:

<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Http\Response;

class AjaxJson
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $response = $next($request);

        if (!$request->ajax()) {
            return $response;
        }

        if (!$response instanceof Response) {
            return $response;
        }

        return response()->json($response->getOriginalContent(), $response->status());
    }
}

What am I doing wrong?

Bump.

That happens on Digital Ocean too. Please help, good people :)

@RoboRobok

Try dump it and see if it's null or what it is when you hit your back button

return var_dump($response);

Once you see what happens, you can deal with it.. just some examples..

return is_null($response) ? abort(401) : $response;

return is_null($response) ? redirect('/') : $response;

return is_null($response) ? 'Ops, I did it again..' : $response;

@SaeedPrez For some reason, now it's fine on my local environment, but still occurs on DigitalOcean. It only happens, when the page is being taken from cache. And it used to be on my Homestead before, now it's loaded each time.

@RoboRobok try with a different browser, see if it solves the problem, could be a browser setting..

@SaeedPrez It's only in Chrome. Do you have an idea how to fix it? I prefer not to accept the fact that some users will be unable to browse back in history :D

@SaeedPrez I solved the problem by adding this middleware:

<?php

namespace App\Http\Middleware;

use Closure;

class DisableCache
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $response = $next($request);

        $response->header('Cache-Control', 'private, max-age=0, no-cache, no-store');

        return $response;
    }
}

I have found out that adding no-store to Cache-Control header prevents Chrome from using cache on back. Any toughts?

It's a whole new full time job keeping up with these browsers, whenever I run into problems like this I try google it, try some stuff, find a solution or workaround and move on.

IMO you shouldn't have AJAX requests on the same as a full HTML URI. A simple search returns a lot about it.

@bashy You are probably right. For now, I'm using same URLs for a few actions. But they are not those that run when I click back button. Do you have an idea why it behaves so weird? When I go back to ANY page, including home page, Google Chrome behaves like it's Ajax page and adds this X-Requested-With: XMLHttpRequest header.

Solution with no-store is, I hope, temporary. I feel like I do something wrong and those same URLs for Ajax and non-Ajax calls might be the reason. I still don't understand why though.

Not seen the issue myself but it must be because of those actions on the page? Sorry I can't help any more.

This cache solution stopped working, I'm now changing all URLs to be separate for Ajax and for non-ajax. I still don't understand this issue though. Why is this header being sent on back?

There was an issue opened for Chrome.

For experiment, I made a middleware that runs if my site is being loaded with Ajax. I was displaying a warning then. What happened, was that on each back in history, this warning was being shown. It's ridiculous.