Level 102
Try running dd on the id to check if its correct
dd($this->id);
Sep 6, 2021
26
Level 1
Validation unique Rule in form request class -> ignore current Id
Hello, I'm asking for a piece of advice and help on how can I add unique rules on name and code when a user tries to store and update product details
Here is the code from the ProductStoreRequest Form request class code
return [
'name' => ['required', Rule::unique('products')->ignore($this->id)],
'code' => ['required', Rule::unique('products')->ignore($this->id)],
'qty' => ['numeric'],
'product_tag' => ['required']
];
when the user tries to store it works perfectly.
if the user tries to update the same product then it should ignore the current id but it gives a validation message for unique value
Here is the API response on update
"errors": [
{
"name": "The name has already been taken."
},
{
"code": "The code has already been taken."
}
]
Is something am I missing, please help me with this! Many thanks!
Level 1
Hey, I'm getting null while dd();, but don't know why!
Level 75
If you are using route model binding then
->ignore($this->route('product')->id)
1 like
Level 1
Hey, I tried your solution but it gives me an error
ErrorException: Trying to get property 'id' of non-object in file E:\www\nginx\...\app\Http\Requests\ProductStoreRequest.php on line 32
Level 75
You have product during updating only.
Level 1
Hi, sorry didn't get you!
but when I try to
'name' => ['required', Rule::unique('products')->ignore($this->product->id)],
it works on the update product function
but the same error will be expected when the products table may empty
ErrorException: Trying to get property 'id' of non-object in file E:\www\nginx\...\app\Http\Requests\ProductStoreRequest.php on line 32
Level 102
You can add a fallback
'name' => ['required', Rule::unique('products')->ignore($this->product->id ?? 0)],
Level 75
@sinnbeck $this->product->id is wrong.
Let's imagine you have
<input name="product">
then you have a problem.
Level 102
@michaloravec +1 Good point :)
But using a fallback (null coalescing operator) is still valid :)
->ignore($this->route('product')->id ?? 0)
Level 1
One more thing I need your guidance
I don't have to manage two separate form request for store product and update product
it is not necessary, right?
Level 75
@sinnbeck Yeah that's alright.
Level 75
I always use two separated form request class with inheritance.
Level 102
But you can use one if you want. It's a matter of personal preference
Level 1
Thank you @michaloravec @sinnbeck this answer helps!
Could you please elabroate the $this->route('product')->id statement?
seems I have confusion for this :)
Level 102
It just gets the $product parameter from the method
https://github.com/laravel/framework/blob/8.x/src/Illuminate/Http/Request.php#L545
Level 1
Thanks! I got it :)
Level 1
Hello @sinnbeck @michaloravec
Could you pls check to help me with this Question, it is a bit urgent. Thanks
Level 7
Can someone please explain why "unique" validation checks the existing record. What are the issues that can occur when setting this to automatic?
Or, at least why can't we have a global config that has it automatically check the record for an ID and if it has an ID, to just ignore self. Would be nice to be able to toggle that option on or off.
PS: only thing I can think of is when I have a [Create] button automatically create a blank record, save it, and redirect to an Edit page. In this case, the default "Unique ignore self" would allow multiple records to have the default value. Though I still can't see how this is worse than the current way unique works.
Level 1
this code helped me.
return [
'name' => ['required', Rule::unique('products','name')->ignore($this->id,'id')],
'code' => ['required', Rule::unique('products','code')->ignore($this->id,'id')],
'qty' => ['numeric'],
'product_tag' => ['required']
];
return [
'name' => ['required', Rule::unique(Product::class,'name')->ignore($this->id,'id')],
'code' => ['required', Rule::unique(Product::class,'code')->ignore($this->id,'id')],
'qty' => ['numeric'],
'product_tag' => ['required']
];
Level 122
@mrbegginerak Is this spam?
Level 1
@Snapey what do you mean by spam ?
Level 122
@mrbegginerak if you have a question then create a question
Dont just post random code and expect help
Level 1
@Snapey I did not post code; I posted an solution. I had also faced this issue and checked this post, but it did not help as much as I expected. So when I found the solution, I posted the answer.
Level 122
@mrbegginerak Your solution only works because you are not using route model binding
Level 1
@Snapey Thank you for your kind words. You're absolutely right; there are often multiple ways to solve a problem. I found this particular solution to be the best fit for my needs, which is why I decided to share it. If anyone else encounters a similar issue, there's a chance that it could be helpful to them as well.
Level 8
public function rules(): array
{
return [
'email' => 'required|string|email|max:255|unique:users,email,'.request()->user()->id
];
}
1 like
Please or to participate in this conversation.