Transform on Paginated Collection removes Pagination

Level 75

You forgot add return from transform.

$rows = Tyre::where('status', 1)->paginate(25);

$results = $rows->getCollection()->transform(function($row, $key) {
    $row->money = number_format($row->retail, 2);

    return $row;
});

$rows = Tyre::where('status', 1)->paginate(25);

foreach ($rows as $row) {
   $row->money = number_format($row->retail, 2);
}

1 like

Snapey

https://talltips.novate.co.uk/laravel/using-a-mutator-to-save-currency

Level 122

why not just add a accessor to the model and render the currency in the view? it saves looping over the data twice

example

southcoastkenny

Level 3

Hi, thanks for the answers

My bad for the typo, i do have a return $row in there, but does not work.

@snapey i do a few more transforms on the row so put that number_format in there for ease as an example.

$results = $rows->getCollection()->transform(function ($row, $key) {
    $row->money = Money::pricing($row->retail, $row->vat);
    $row->trade = Money::pricing($row->tradeprice, $row->vat);
    $row->wsale = Money::pricing($row->wsaleprice, $row->vat);
    return $row;
}

Where money is a function that calculate exchange rates, and format pricing into a an array containing multiple values.

But it just wipes the pagination from the collection and returns just the items:

Illuminate\Database\Eloquent\Collection {#1895 ▼
  #items: array:7 [▼
    0 => App\Models\Tyre {#1896 ▶}
    1 => App\Models\Tyre {#1897 ▶}
    2 => App\Models\Tyre {#1898 ▶}
    3 => App\Models\Tyre {#1899 ▶}
    4 => App\Models\Tyre {#1900 ▶}
    5 => App\Models\Tyre {#1901 ▶}
    6 => App\Models\Tyre {#1902 ▶}
  ]
}

Many Thanks

Snapey

Level 122

I'm not familiar with getCollection() Where/how did you know to use that?

ps. I'd still use accessors

Best Answer

Level 75

@southcoastkenny Don't create new variable $results, but just do it on the same variable.

$rows = Tyre::where('status', 1)->paginate(25);

$rows->getCollection()->transform(function ($row, $key) {
    $row->money = Money::pricing($row->retail, $row->vat);
    
    $row->trade = Money::pricing($row->tradeprice, $row->vat);

    $row->wsale = Money::pricing($row->wsaleprice, $row->vat);
    
    return $row;
});

return view('some-view', compact($rows));

In the view this will be still work

$rows->links();

4 likes

fahmidotexe

Level 1

@MichalOravec I use laravel 8 and getCollection() is undefined, when I remove it, it works. Now, when I use transform, it still wipe out the pagination props when returning to json or inertia, help?

Level 75

@fahmidotexe Create your own thread.

fahmidotexe

Level 1

@MichalOravec apologize, I thought it was still relevant. I was asked this in SO and discord but haven't yet get answer and almost a half year now. So sorry 🙏.

Level 75

@fahmidotexe How I said, create your own thread, the solution is very simple...

southcoastkenny

Level 3

Hi,

Thank you @michaloravec Ive been scratching my head for 2 days on that. Works perfectly.

Kenny.

kbcs

Level 1

Hi, have similarly issue but @MichalOravec solution help me so much. Thanks once again

tykus

https://laravel.com/api/8.x/Illuminate/Pagination/AbstractPaginator.html#method_through

Level 104

Pagination classes have a through method which allows you to fluently iterate over the items in the Collection transforming each item. This is much cleaner than getting the Collection IMHO


$rows = Tyre::where('status', 1)->paginate(25)
    ->through(function ($row, $key) {
        $row->money = Money::pricing($row->retail, $row->vat);
        $row->trade = Money::pricing($row->tradeprice, $row->vat);
        $row->wsale = Money::pricing($row->wsaleprice, $row->vat);
        return $row;
    });

2 likes

https://github.com/laravel/framework/pull/34657

Level 75

@tykus Yeah of course, it was added to Laravel in October 2020, a few months after this thread was solved.

@fahmidotexe This is exactly what I meant that the solution is very simple...

tykus