Test cases take 167.67s to execute

@tykus oh my bad, actually 20 test cases checks for emails has been sent or not.

@martinbean Hey martin,

I wrote test like this.

    public function testSuccess()
    {
        Storage::fake('s3');

        $data = [
            'file' => UploadedFile::fake()->image('test_image.png'),
        ];

        $response = $this->post('api/upload/statements', $data);
        $response
            ->assertStatus(200);

        Storage::disk('s3')->assertExists($response->json('file_name'));
    }

and my api code is here

	public function handleUploadStatement(Request $request) {
		
		$filename = uniqid() . '.' . $request->file->getClientOriginalExtension();
		Storage::disk('s3')->put('docs/'.$filename, file_get_contents($request->file));
		
return response()->json([
				'file_name' => 'docs/'.$filename,
		]);
	}

Please correct this where I'm missing.

@amitsolanki24_ Why are you generating filenames yourself? You don’t need to. The docs show you how to upload a file with a unique filename: https://laravel.com/docs/requests#storing-uploaded-files

If you had followed the docs, then uploading a file would be a one-liner:

public function handleUploadStatement(Request $request)
{
    $path = $request->file('file')->store('docs');

    return response()->json([
        'file_name' => $path,
    ]);
}

You should probably also validate whether a user is actually providing a file in the request data, and that the value is, in fact, a file. Right now, your controller action is going to throw an error if they don’t sent a file parameter, or if they do send a file parameter but it contains anything other than a file (for example: a string, a number, an array, etc).

@martinbean Thanks for your valuable comment.

Why are you generating filenames yourself?

$path = $request->file('file')->store('docs');

Because I don't prefer this approach, yeah it's to short but I don't like that's why I used that.

Yeah, I am validating the file but the code is not shown here, only the important one is shown in the comment.

@amitsolanki24_ What’s the point of using a framework like Laravel if you’re not going to take advantage of the features it offers you and instead re-invent the wheel? 🤷‍♂️

@martinbean yeah, laravel framework provide amazing features but Storage facade appears more user friendly or provide readability.