Target [App\Http\Services\Bookshelf] is not instantiable while building [App\Http\Controllers\BookController].

Please show corresponding rows from routes/web.php and full file BookController.php.

Your book controller needs something when it is being constructed, that the framework does not know how to create.

More of the error message would help, and as has been asked, the entire controller.

I cant see anything here where you use Bookshelf service.

Some tips about your code

if ($book->update($request->all()) === false) {
        return response(
            "Couldn't update the user with id {$request->id}",
            Response::HTTP_BAD_REQUEST
        );
    }

This sort of pattern is useless. If something goes wrong in the update then an exception will be thrown, and your if () test will never execute.

If you want to capture the exception and show a custom message, then use try-catch.

The most likely cause of errors is invalid or incomplete data. Avoid using request->all() and only send validated data to your model.

thank you, sorry for the mistake

controller:

<?php

namespace App\Http\Controllers;

use App\Models\Book;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Symfony\Component\HttpFoundation\Response;
class BookController extends Controller
{
    public function getBooklist(Request $request, Book $book): RedirectResponse
    {
        foreach ($book as $ibooks) {
            echo $ibooks->author = $request->author;
        }
        return redirect('bookshelf.blade.php');
    }

    public function storeBook(Request $request)
    {
        $validated = $request->validate([
            'title' => 'required|string|max:255',
            'summary' => 'required',
            'pages' => 'required|integer',
            'genre' => 'required|string',
            'author' => 'required|string',
            'color' => 'required|string',
            'price' => 'required|numeric',
            'photo' => 'nullable|image|max:2048',
        ]);

        if ($request->hasFile('photo')) {
            $filename = time() . '.' . $request->photo->extension();
            $request->photo->move(public_path('images'), $filename);
            $validated['photo'] = $filename;
        }

        Book::create($validated);

        return redirect()->back()->with('success', 'Book added');
    }


    public function deleteBook(Book $book): RedirectResponse
    {
        $book->delete();

        echo ("Book deleted successfully!");

        $nano = time_nanosleep(2, 100000);

        if ($nano === true) {
            echo "Slept for 2 seconds, 100 microseconds.\n";
        } elseif ($nano === false) {
            echo "Sleeping failed.\n";
        } elseif (is_array($nano)) {
            $seconds = $nano['seconds'];
            $nanoseconds = $nano['nanoseconds'];
            echo "Interrupted by a signal.\n";
            echo "Time remaining: $seconds seconds, $nanoseconds nanoseconds.";
        }

        return redirect('/bookshelf');
    }

    public function updateBook(Request $request): Response
    {
        $book = Book::findOrFail($request->id);

        if ($book->update($request->all()) === false) {
            return response(
                "Couldn't update the user with id {$request->id}",
                Response::HTTP_BAD_REQUEST
            );
        }

        return response($book);
    }

    public function getSingleBook(Request $request, Book $book): Response
    {
        $book->get();

        return response($book);
    }

}

this is the routes:

<?php

use App\Http\Controllers\BookController;
use App\Models\Book;
use Illuminate\Support\Facades\Route;



Route::get('/', function () {
    $books = Book::all();
    return view('books.index', compact('books'));
});

Route::get('/get', [BookController::class, 'getBooklist'])->name('getBooks');
Route::post('/create', [BookController::class, 'storeBook'])->name('newBook');
Route::delete('/delete', [BookController::class, 'deleteBook'])->name('delBook');
Route::patch('/update/3', [BookController::class, 'updateBook'])->name('updateBook');
Route::get('/get/2', [BookController::class, 'getSingleBook'])->name('singleBook');

require __DIR__.'/settings.php';
require __DIR__.'/auth.php';
 

@Staxidibus_Aeternam there is no BookShelf class mentioned in your controller or routes. Have you ever written the class App\Http\Services\Bookshelf by yourself? Does it ever exist? Can you post this file?

Also, what is the exact situation where you get the error?

What does it contribute to the project, and how is it instantiated? Sorry, its not a pattern I am familiar with

it shouldn't do anything to contribute to the project rn. I never call it in my controller and i'm just trying to create a book, but when i submit the form it gives me this error

@staxidibus_aeternam is you are getting this error in the in the getBooklist() method ????

also i think you are getBookList() is wrong if you are fetching all the books then it should be like this

public function getBooklist(): RedirectResponse
{
    $books = Book::all(); // Get all books

	//using URL
    return redirect('/bookshelf')->with('books', $books);

	//using route name
    return redirect()->route('get')->with('books', $books);

	//either you can directly pass to the blade file like this 
	return view('bookshelf' , compact('books'));								
}

1 . Incorrect Parameter Usage (Book $book)

• You're injecting a single Book model, but treating it like a collection in foreach.

• If you want all books, use Book::all() instead.

Redirecting to a Blade File (Incorrect)

• redirect('bookshelf.blade.php') is wrong—you should redirect to a route name or URL or direct to the blade file (e.g., /bookshelf) .

as for your default route you can do something like this

Route::get('/', function()  { 
	return redirect()->route('getBooks'));
});

if you have any more app code, that you didn't write and you don't know why its there, its probably best to delete it !