Running php artisan test results in 3 failed, 4 skipped, 26 passed

@rodrigo.pedra I haven't touched anything on the related controllers. I've never removed any controller. What can I do? I feel confused..

@rodrigo.pedra This is how my for example AuthenticationTest looks like

<?php

namespace Tests\Feature;

use App\Models\User;
use App\Providers\RouteServiceProvider;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;

class AuthenticationTest extends TestCase
{
    use RefreshDatabase;

    public function test_login_screen_can_be_rendered()
    {
        $response = $this->get('/login');

        $response->assertStatus(200);
    }

    public function test_users_can_authenticate_using_the_login_screen()
    {
        $user = User::factory()->create();

        $response = $this->post('/login', [
            'email' => $user->email,
            'password' => 'password',
        ]);

        $this->assertAuthenticated();
        $response->assertRedirect(RouteServiceProvider::HOME);
    }

    public function test_users_can_not_authenticate_with_invalid_password()
    {
        $user = User::factory()->create();

        $this->post('/login', [
            'email' => $user->email,
            'password' => 'wrong-password',
        ]);

        $this->assertGuest();
    }
}

it is untouched. Out of the box. Should I edit something?

@migsAV Yeah, I've changed some simple logic like where to redirect after login based on user type. Also added some additional columns to the users table.

@Laralex

The redirect change already explains the AuthenticationTest failure.

On the test case that is failing test_users_can_authenticate_using_the_login_screen, the last assertion checks if the response redirects the user to the path defined in RouteServiceProvider::HOME.

If you changed where the controller redirects after logging an user in, this assertion will fail until you fix it.

There are the kind of changes I referred to on my first answer. If you change the code being testes, most likely some tests will start failing.

@rodrigo.pedra Here's how I changed the authentication redirect

https://laracasts.com/discuss/channels/laravel/change-default-redirect-after-loginregister

I think there is nothing wrong in this. I need to keep that redirection no matter what. What to do, guys?

@migsAV I'm getting

  • Tests\Feature\AuthenticationTest > users can authenticate using the login screen
   Illuminate\Validation\ValidationException

  The given data was invalid.

That's how my user factory looks

<?php

namespace Database\Factories;

use App\Models\Team;
use App\Models\User;
use Illuminate\Database\Eloquent\Factories\Factory;
use Illuminate\Support\Str;
use Laravel\Jetstream\Features;

class UserFactory extends Factory
{
    /**
     * The name of the factory's corresponding model.
     *
     * @var string
     */
    protected $model = User::class;

    /**
     * Define the model's default state.
     *
     * @return array
     */
    public function definition()
    {
        $arr = config('app.colors');
        $rand = array_rand($arr);
        return [
            'name' => $this->faker->name(),
            'email' => $this->faker->unique()->safeEmail(),
            'email_verified_at' => now(),
            'password' => 'yIXUNpkjO0rOQ5byMi.Ye4oKoEa3Ro9llC/.og/at2.uheWG/igi', // password
            'remember_token' => Str::random(10),
            'bgColor' => $arr[$rand]['background'],
            'textColor' => $arr[$rand]['text'],
        ];
    }

    /**
     * Indicate that the model's email address should be unverified.
     *
     * @return \Illuminate\Database\Eloquent\Factories\Factory
     */
    public function unverified()
    {
        return $this->state(function (array $attributes) {
            return [
                'email_verified_at' => null,
            ];
        });
    }

    /**
     * Indicate that the user should have a personal team.
     *
     * @return $this
     */
    public function withPersonalTeam()
    {
        if (! Features::hasTeamFeatures()) {
            return $this->state([]);
        }

        return $this->has(
            Team::factory()
                ->state(function (array $attributes, User $user) {
                    return ['name' => $user->name.'\'s Team', 'user_id' => $user->id, 'personal_team' => true];
                }),
            'ownedTeams'
        );
    }
}

@Laralex try this and see it the authentication test passes

public function definition()
    {
       // $arr = config('app.colors');
       // $rand = array_rand($arr);
        return [
            'name' => $this->faker->name(),
            'email' => $this->faker->unique()->safeEmail(),
            'email_verified_at' => now(),
            'password' => 'yIXUNpkjO0rOQ5byMi.Ye4oKoEa3Ro9llC/.og/at2.uheWG/igi', // password
            'remember_token' => Str::random(10),
         //   'bgColor' => $arr[$rand]['background'],
          //  'textColor' => $arr[$rand]['text'],
        ];
    }

@migsAV Now I have

  Tests:  8 failed, 4 skipped, 21 passed

@laralex then you need to retrace your steps because you have changed something that is affecting your tests.

You mentioned you changed the redirect, this will affect your tests

@migsAV Yeah, I've changed some simple logic like where to redirect after login based on user type. Also added some additional columns to the users table.

You got to remember that a slight change in how the login works will sometimes cause failed tests