Returning a generated token in a test

Have you tried dumping the response to see what it contains in your test as you postman output looks correct?

$response = $this->json('POST', '/api/login', $payload);
dd($response->toArray());

If you are seeing the token I would add a test for

->assertJsonCount(1, 'data.token');

You might need to tinker with the last argument depending on the output of the dd()

@D9705996 I get the following error

BadMethodCallException: Method Illuminate\Http\JsonResponse::toArray does not exist.

@Chris1981 - sorry just dd($response);

@D9705996 thats ok .. This is what i am getting using dd($response)

+original: array:3 [
    "success" => true
    "message" => "Yehhh Boiiiii"
    "data" => array:1 [
        "token" => "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJodHRwOlwvXC9sb2NhbGhvc3RcL2FwaVwvbG9naW4iLCJpYXQiOjE1MzkzMzM0NjMsImV4cCI6MTUzOTMzNzA2MywibmJmIjoxNTM5MzMzNDYzLCJqdGkiOiJscTNMVE00Q2FIbkJiUTlUIiwic3ViIjoxLCJwcnYiOiIyM2JkNWM4OTQ5ZjYwMGFkYjM5ZTcwMWM0MDA4NzJkYjdhNTk3NmY3In0.2ufSUEmW6FwxirRHrPU5tyb-Y9zrBss4ap0oIHxny2Y"
    ]
]

The token is there, but I just cant seem to get it into the assert statement

You need a second assertion as you don't know what the value of the token will be.

Try ->assertJsonCount(1, 'data.token');

@D9705996 damn, now im getting the following;

PHPUnit\Framework\Exception: Argument #2 (No Value) of PHPUnit\Framework\Assert::assertCount() must be a countable or iterable

My whole test is as follows;

public function it_logs_a_user_in()
{
    $user = factory(User::class)->create([ 'password' => Hash::make('foobar') ]);
    $payload = [ 'email' => $user->email, 'password' => 'foobar' ];

    $response = $this->json('POST', '/api/login', $payload);
    $response->assertStatus(200)
        ->assertJsonFragment([
            'success' => true,
            'message' => 'Yehhh Boiiiii'
        ])
        ->assertJsonCount(1, 'data.token');
}

You can assert that there is a token key in the json structure:

$response->assertJsonStructure([
    'success',
    'message',
    'data' => [
        'token'
    ]
]);

@tykus that doesn't check to see if there is a value in the token though does it?

@chris1981 - I often just convert the json response to an array/collection then use native PHPUnit assertions

$response = json_decode($this->json('POST', '/api/login', $payload)->getContent());
$this->assertNotNull($response['data']['token']);

No. But if you really wanted to, you could now check that there is a token using:

$this->assertNotNull(
    json_decode($response->getContent()['data']['token'])
);

In combination, with the structure assertion above, you have done as much as you can barring a regex on the token value

@D9705996 Sorry to be a pain, but thats also erroring out.

ErrorException: json_decode() expects parameter 1 to be string, object given

@tykus im also getting an error from this

ErrorException: Illegal string offset 'data'

I wouldn't bother trying do a regex on the token value. I would have a second test that gets a token then uses it and assert that you get the expected behaviour with a valid token.

Not doing well today, I missed getContent()...

$response = json_decode($this->json('POST', '/api/login', $payload)->getContent());
$this->assertNotNull($response['data']['token']);

I missed true as second argument to json_decode so that you are dealing wiuth a nested array.

$responseData =  json_decode($response->getContent(), true);
$this->assertNotNull(
   $responseData['data']['token'])
);

I wouldn't regex the token either, my point was that you are doing as much as is reasonable already if you know you are getting a token and it is not null

Thanks guys, thats worked now :)

Much appreciated for all your help, sorry about the back and forth.

@Chris1981 - could you please mark the discussion as solved

Sure thing :)