Level 104
ContactResource::collection($this->contacts)
Oct 19, 2022
31
Level 7
relationship resource file and how to include that to show an array of contact for company?
Hi I currently have a relationship between two tables, Contacts Companies
Great I am getting an object of company for each contact but when I try and get an an array of contacts for each company I'm just getting NULL back?! company resource:
<?php
namespace App\Http\Resources;
use App\Http\Resources\ContactResource;
use Illuminate\Http\Resources\Json\JsonResource;
class CompanyResource extends JsonResource
{
/**
* Transform the resource into an array.
*
* @param \Illuminate\Http\Request $request
* @return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable
*/
public function toArray($request)
{
return [
"id" => $this->id,
"name" => $this->name,
"email" => $this->email,
"phone" => $this->phone,
"address" => $this->address,
"town_city" => $this->town_city,
"region_county" => $this->region_county,
"country_code" => $this->country_code,
"post_code" => $this->post_code,
"contacts" => new ContactResource($this->contact)
];
}
}
Company model:
public function contacts() {
return $this->hasMany(Contact::class, 'contact_id', 'id');
}
Level 7
@tykus I used this in the CompanyResource and it doesn't like it:
<?php
namespace App\Http\Resources;
use App\Http\Resources\ContactResource;
use Illuminate\Http\Resources\Json\JsonResource;
class CompanyResource extends JsonResource
{
/**
* Transform the resource into an array.
*
* @param \Illuminate\Http\Request $request
* @return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable
*/
public function toArray($request)
{
return [
"id" => $this->id,
"name" => $this->name,
"email" => $this->email,
"phone" => $this->phone,
"address" => $this->address,
"town_city" => $this->town_city,
"region_county" => $this->region_county,
"country_code" => $this->country_code,
"post_code" => $this->post_code,
"contacts" => new ContactResource::collection($this->contact)
];
}
}
it's saying: syntax error, unexpected identifier "collection", expecting variable or "$" Unexpected 'Name'.intelephense(1001)
Level 104
@boyjarv no new
"contacts" => ContactResource::collection($this->contacts)
1 like
Level 19
::collection is a static method (i.e., you don't instantiate an object to use it). The last line should be
"contacts" => ContactResource::collection($this->contact)
Level 3
@boyjarv Include contacts when you call company model like this:
'contacts' => ContactResource::collection($this->contacts),
Try $this->contacts instead of $this->contact. Because there is HasMany relation for contacts
Level 7
Thank you!
Level 7
now I'm getting:
Column not found: 1054 Unknown column 'contacts.contact_id' in 'where clause' (SQL: select * from `contacts` where `contacts`.`contact_id` = 1 and `contacts`.`contact_id` is not null) in file /Users/johnbiddulph/Documents/jbsites/laravel/laravel-jwt/vendor/laravel/framework/src/Illuminate/Database/Connection.php on line 759
Level 7
company model:
<?php
namespace App\Models;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use App\Models\Contact;
class Company extends Model
{
use HasFactory;
protected $fillable = [
'first_name',
'last_name',
'email',
'phone',
'address',
'town_city',
'region_county',
'country_code',
'post_code',
'notes'
];
public function contacts() {
return $this->hasMany(Contact::class, 'contact_id', 'id');
}
}
contact model:
<?php
namespace App\Models;
use App\Models\Company;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
class Contact extends Model
{
use HasFactory;
protected $fillable = [
'company_id',
'first_name',
'last_name',
'email',
'phone',
'address',
'town_city',
'region_county',
'country_code',
'post_code'
];
public function company() {
return $this->belongsTo(Company::class, 'company_id', 'id');
}
}
Level 3
@boyjarv Can you show the exact query where you are trying to get contacts?
Level 7
I think it's this line that is wrong as there is no contact_id - not sure what to change it to?!
I changed it to
public function contacts() {
return $this->hasMany(Contact::class, 'id', 'contact_id');
}
I am now getting an empty array for each company?!
{
"id": 4,
"name": "Hayes-Spinka",
"email": "charlotte.gorczany.com"
"contacts": []
},
Level 104
@boyjarv the Contact has a company_id which should be used in the relationship by default; you don't need to specify the FK unless it is non-conventional:
// Company model
public function contacts()
{
return $this->hasMany(Contact::class);
}
// Contact model
public function company()
{
return $this->belongsTo(Company::class);
}
Level 3
@boyjarv Try to update you relation to this:
public function contacts() { return $this->hasMany(Contact::class, 'company_id', 'id'); }
Level 7
postman is saying:
Error: socket hang up I've tried:
public function contacts()
{
return $this->hasMany(Contact::class);
}
and
public function contacts()
{
return $this->hasMany(Contact::class, 'company_id', 'id');
}
Level 104
@boyjarv have you tried visiting the endpoint in a Browser?
Level 7
I'm. now getting:
Error: Call to a member function first() on null in file /Users/johnbiddulph/Documents/jbsites/laravel/laravel-jwt/vendor/laravel/framework/src/Illuminate/Http/Resources/CollectsResources.php on line 34
Level 104
@boyjarv can you show the full toArray methods for the Resource class(es) - it seems you are passing null where a Collection is expected
Level 7
CompanyResource:
<?php
namespace App\Http\Resources;
use App\Http\Resources\ContactResource;
use Illuminate\Http\Resources\Json\JsonResource;
class CompanyResource extends JsonResource
{
/**
* Transform the resource into an array.
*
* @param \Illuminate\Http\Request $request
* @return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable
*/
public function toArray($request)
{
return [
"id" => $this->id,
"name" => $this->name,
"email" => $this->email,
"phone" => $this->phone,
"address" => $this->address,
"town_city" => $this->town_city,
"region_county" => $this->region_county,
"country_code" => $this->country_code,
"post_code" => $this->post_code,
"contacts" => ContactResource::collection($this->contact)
];
}
}
ContactResource:
<?php
namespace App\Http\Resources;
use App\Http\Resources\CompanyResource;
use Illuminate\Http\Resources\Json\JsonResource;
class ContactResource extends JsonResource
{
/**
* Transform the resource into an array.
*
* @param \Illuminate\Http\Request $request
* @return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable
*/
public function toArray($request)
{
return [
"id" => $this->id,
"first_name" => $this->first_name,
"last_name" => $this->last_name,
"email" => $this->email,
"phone" => $this->phone,
"address" => $this->address,
"town_city" => $this->town_city,
"region_county" => $this->region_county,
"country_code" => $this->country_code,
"post_code" => $this->post_code,
"created_at" => $this->created_at,
"company" => new CompanyResource($this->company)
];
}
}
Level 104
@boyjarv the relationship is contacts, not contact, right?
"contacts" => ContactResource::collection($this->contacts)
Level 7
@tykus yes thats right ,
I've tried this:
"contacts" => ContactResource::collection($this->contacts)
but it doesn't work, Laravel breaks and changes the localhost to: http://127.0.0.1:8001 I have to run php artisan serve again
here is the relationship in the Company model
public function contacts() {
return $this->hasMany(Contact::class);
}
Level 104
it doesn't work, Laravel breaks and changes the localhost to: http://127.0.0.1:8001
Because of that one line, really? Is there anything in the logs?
Level 7
@tykus Where is my Laravel logs file? I can't see it anywhere
Level 7
ok so I found storage/logs log file I cleared it out re-ran php artisan serve and then logged in and clicked on Companies, nothing was written to the log file
Level 104
@boyjarv but the built-in server stopped again????
Level 7
@tykus yes
Level 104
@boyjarv and is this just happening since you added that ContactResource::collection($this->contacts) line???
Something is not adding up here.
Level 7
@tykus yes
Level 7
@tykus I really appreciate you trying to help me out here, I just pushed my Laravel project to my repo: https://github.com/jbiddulph/vue-crm-backend
Level 104
@boyjarv ok I believe you are getting an infinite loop because the ContactResource returns the CompanyResource, and the CompanyResource returns the ContactResource and so on...
You can instead conditionally load either
Level 7
@tykus Thank you for this @tykus
In my Contact Resource I have:
return [
"id" => $this->id,
"first_name" => $this->first_name,
"last_name" => $this->last_name,
"email" => $this->email,
"phone" => $this->phone,
"address" => $this->address,
"town_city" => $this->town_city,
"region_county" => $this->region_county,
"country_code" => $this->country_code,
"post_code" => $this->post_code,
"created_at" => $this->created_at,
"company" => new CompanyResource($this->whenLoaded('company'))
];
and the CompanyResource I have:
return [
"id" => $this->id,
"name" => $this->name,
"email" => $this->email,
"phone" => $this->phone,
"address" => $this->address,
"town_city" => $this->town_city,
"region_county" => $this->region_county,
"country_code" => $this->country_code,
"post_code" => $this->post_code,
"contacts" => ContactResource::collection($this->contacts)
];
the Contacts now are showing for each company but the company is now not showing for the contacts?!
1 like
Level 104
@boyjarv what do you suppose whenLoaded means? You would need to load the company relationship on the contacts if you want to display it, e.g. in the Controller before you make the top level Company resource
$company->load('contacts.company');
Make sure you conditionally load the contacts in the CompanyResource, or you go into another infinite loop
ContactResource::collection($this->whenLoaded($this->contacts))
BUT what is the purpose of your Resources showing contacts inside company, and company inside each contact, and contacts inside company, and company inside each contact, and contacts inside company, and company inside each contact, and ... so on? It's got to end somewhere!
Level 7
@tykus Thank you so much for your help! I modified my Contact Controller to:
public function index()
{
$contacts = Contact::paginate(15);
return ContactResource::collection($contacts->load('company'));
}
Please or to participate in this conversation.