Problem when updating resources

Hi @warpig

What are you getting back instead of an updated post? An error? The post without changes?

Just in case...your update method doesn't do anything at all with the post, so you should be getting the post as it was...

Or you haven't copied the code inside the update just to simplify?

If that's the case, please copy the entire code to see what could be going on

Like @marianomoreyra say you need to update the post something like this should do the trick.

public function update(Post $post, PostFormRequest $request)
    {
        $post->update($request->validated());
    }

That is you are using FormRequests for your validation otherwise you can do something like this

 
public function update(Post $post, Request $request)
    {
        $post->update(['post' => $request->post]);
    }

Just add the fields to the array.

You need to put

$post->update();

before you redirect.

Or do this.

public function update(Post $post, Request $request)
    {
        $post->update([
		'title' => $request->title,
		'body' => $request->body,
		'slug' => $request->slug
	]);
    }

One thing though is that you need to validate before storing it in the database.

Sorry most of what you guys have been answering has been returning an empty array, a 404 or an error, really dont know whats going on but i will add how the posts table looks like.. and I will specify each way i tried to apply to the function, since ive tried in several ways. What else could i share so you guys can review? Cheers! @tray2 @marianomoreyra

create_posts_table.php

    public function up()
    {
        Schema::create('posts', function (Blueprint $table) {
            $table->id();
            $table->text('title');
            $table->string('slug');
            $table->text('body');
            $table->timestamps();
            $table->timestamp('published_at')->nullable();
        });
    }

This one threw a 404 error. When i added die($post) on this though, the browser rendered the updated post correctly, but once i removed that part it was a 404.

    public function update(Post $post, Request $request)
    {   
        $post->title = request('title');
        $post->body = request('body');
        $post->slug = request('slug');

        $post->update();

        return redirect('posts/' . $post->slug);
    }

This says Method Illuminate\Http\Request::validated does not exist.

    public function update(Post $post, Request $request)
    {   
        $post->update($request->validated());
        return redirect('posts/' . $post->slug);
    }

And since i thought maybe @tray2 wanted to type "validate" instead of "validated" on this method this happened:

Too few arguments to function Illuminate\Http\Request::Illuminate\Foundation\Providers\{closure}(), 0 passed in /Users/eduardocoello/Projects/newport/vendor/laravel/framework/src/Illuminate/Macroable/Traits/Macroable.php on line 114 and exactly 1 expected 

This way it returned an empty array when the die method was applied, which meant that the post didnt update:

    public function update(Post $post, Request $request)
    {   
        $post->update(['post' => $request->post]);
        return redirect('posts/' . $post->slug);
    }

Also an empty array:

    public function update(Post $post, Request $request)
    {   
        $post->update([
            'title' => $request->title,
            'body' => $request->body,
            'slug' => $request->slug
        ]);
        return redirect('posts/' . $post->slug);
    }

Empty array:

    public function update(Post $post, Request $request)
    {   
        $validatedData = $request->validate([
            'title' => 'required|unique:posts|max:255',
            'body'  => 'required',
            'slug'  => 'required',
        ]);
    
        $post->update($validatedData);
        return redirect('posts/' . $post->slug);
    }

Last attempt looks like this, threw a 404:

    public function update(Post $post, Request $request)
    {   
        $post->title = request('title');
        $post->body = request('body');
        $post->slug = request('slug');
        
        $post->update(['post' => $request->post]);
        return redirect('posts/' . $post->slug);
    }

Complete form field

    <form method="POST" action="/posts/{{ $post->slug }}" class="newpost-form">
        @csrf
        
        @method('PUT')

        <h1> UPDATE POST </h1>
            <div class="" data-validate="Title is required">
                <span class=""> Title </span>
                <input class="" type="text" name="title" placeholder="Title" value="{{ $post->title }}">
            </div> <!-- Title field -->

            <div class="" data-validate="Body is required">
                <span class=""> Body </span>
                <textarea rows="30" cols="50" name="body" class="tinyMCE" id="bodyArea" placeholder="Body">{{ $post->body }}</textarea>
            </div> <!-- Message field --> 

        <section id="tagslug">
            <div data-validate="Slug is required">
                <span> Slug </span>
                <input type="text" name="slug" placeholder="Slug" value="{{ $post->slug }}">
            </div> <!-- Slug field end -->

            <!-- <div class="" data-validate="Tags are required">
                <span> Tags </span>
                <input type="text" name="tags" placeholder="Tags">
            </div> Tag field end -->
        </section> <!-- Slug & Tags end -->
            
            <div>
                <button class="btn-submit">Submit</button>
            </div> <!-- Submit button -->
    </form> <!-- Form end -->

Watch this series https://laracasts.com/series/laravel-6-from-scratch because you have a problem with basics.

@warpig I've just realized something...

Is this your entire Post model?

class Post extends Model
{
    public function getRouteKeyName()
    {
        return 'slug';
    }
    
    use HasFactory;
}

if that's the case, you need to add a $fillable or $guarded property to allow mass assignment.

ref: https://laravel.com/docs/8.x/eloquent#mass-assignment

Try with this for now:

class Post extends Model
{
    protected $guarded = [];

    public function getRouteKeyName()
    {
        return 'slug';
    }
    
    use HasFactory;
}

with the following update method:

    public function update(Request $request, Post $post)
    {   
        $post->title = request('title');
        $post->body = request('body');
        $post->slug = request('slug');

        $post->save();

        return redirect('posts/' . $post->slug);
    }

EDIT: Changed the ->update() to ->save() and added reference to mass assignment on docs.