Level 31
Dec 13, 2019
51
Level 1
pass Slug and localization to route
Hi everyone.. I working on a website with two language to show success stories .. the problem start when click read More I get an issue when I pass the param of slug to the route, this is my route in balde :
<a href="{{route('success_details',['slug' => $story->slug,'locale' => App()->getLocale()]) }}" >Read More</a>
in the web.php :
Route::get('success','HomPageController@success')->name('success');
Route::get('success/{slug}','HomPageController@success_details')->name('success_details');
this is the controller
public function success_details($slug)
{
$story = Story::where('id', request()->slug)
->orWhere('slug', request()->slug)
->firstOrFail();
return view('user.stories_details', compact('story'));
}
the error message :
Facade\Ignition\Exceptions\ViewException
Missing required parameters for [Route: success_details] [URI: {locale}/success/{slug}]. (View:
C:\Users\ManOf360\Desktop\success_story\resources\views\user\layouts\header.blade.php)
http://127.0.0.1:8000/en/success/domind-in-the-stone-of-muntinte
and this is the header.blade.php :
<li>
<a href="{{route('success',app()->getLocale())}}">@lang('header.Success Stories')</a>
</li>
help please :)
Level 122
how can the route helper know that locale is required? Is the route inside a route group that accepts locale ?
Level 1
@martal the reslut of check by dd() ;
dd( $story->slug); = "domind-in-the-stone-of-muntinte"
dd( App()->getLocale()); = "en"
so no null
Level 1
@snapey yes Mr : @snapey the route inside this code :
Route::group(['prefix' => '{locale}', 'where' => ['locale' => 'en|fa|ar'],'middleware' => 'setlocale'],function (){
Route::get('success','HomPageController@success')->name('success');
Route::get('success/{slug}','HomPageController@success_details')->name('success_details'); });
Level 31
Sounds crazy, but may be you should use lowercased helper function app() in blade? Like this
<a href="{{route('success_details', ['slug' => $story->slug,'locale' => app()->getLocale()]) }}" >Read More</a>
And, by the way, did you call route('success_details',[...]) only in that place? Do you have another calls to it?
Level 1
Level 31
Sorry, not enough data to find the reason of the error.
Could not you show a full error message?
And also, please, show php artisan route:list --path=success output.
Level 1
this is the head of error
facade\Ignition\Exceptions\ViewException Missing required parameters for [Route: success_details] [URI: {locale}/success/{slug}]. (View: C:\Users\ManOf360\Desktop\BFD+Admin- zero to hero\BFD_Org\resources\views\user\layouts\header.blade.php) http://127.0.0.1:8000/en/success/domind-in-the-stone-of-muntinte
and this is the code
<?php
namespace Illuminate\Routing\Exceptions;
use Exception;
class UrlGenerationException extends Exception
{
/**
* Create a new exception for missing route parameters.
*
* @param \Illuminate\Routing\Route $route
* @return static
*/
public static function forMissingParameters($route)
{
return new static("Missing required parameters for [Route: {$route->getName()}] [URI: {$route->uri()}].");
}
}
Level 1
@martal this the outbout :
| Domain | Method | URI | Name | Action | Middleware |
+--------+----------+-------------------------+-----------------+-----------------------------+---------------+|
| GET|HEAD | {locale}/success/{slug} | success_details | App\Http\Controllers\HomPageController@success_details | web,setlocale |
Level 31
Sorry for being unclear. I meant full error message in browser window.
I cannot get access to you localhost to see it myself.(=
1 like
Level 31
What if not to start a uri with a parameter?
To make something like posts/{locale}/success/{slug} instead? Will it work?
Level 1
@martal this is the full page error in this url
http://www.clipular.com/c/5480782611873792.png?k=sR8tai-8efqWx1oudcrscbfHuQc
Level 1
Level 31
Sorry, was absent.
Did you find the error?
Did you try to change route as I had said?
Level 1
till now no .!
I do not want to change the route to be as you said , because I have a lot of routs .
š
Level 31
But you could change it temporarily to find out whether the parameter on the first position was the reason of your error or not.
Sorry, I do not have enough data to assume another reason of your error.
Level 1
Hi Mr: @martal thanks a lot for your helping š .. finally it's work š¤ .
I change the routes to take the second parameter as optional ( {$slug?} )
like this :
Route::get('success','HomPageController@success')->name('success');
Route::get('success/{slug?}','HomPageController@success_details')->name('success_details');
and in the blade :
<a href="{{route('success_details',['locale' => app()->getLocale(), 'slug' => $story->slug])}}" class="read-
more">Read More</a>
Level 122
I don't like the fact that this works but we don't know why. Making the slug optional should have no effect.
What you have also done is altered the order of the array passed to the route helper. This should not matter but could be relevant?
1 like
Level 31
Making slug optional means that it could be null in some cases. I had said that it seemed like slug is null, but you answered that it was not.
Level 1
yes Mr: @snapey even me I don't like the fact that this works but we don't know why > and really I still afraid about this routes , but what can I do
Level 1
yes every time I check the slug it was not null .. and really I don't know another way for now /
Level 31
If you have enough time it is better to find out what was the reason.
May be there is a bug in laravel. You could find it out and fix. If you want of course.
Level 31
dd($slug); stops execution of a script. And error (null value in our case) could be not on the first $slug but on second (if you have some).
You can use logger('Slug is', [$slug]); to log data without stopping execution.
1 like
Level 122
Your route statement that is throwing the error, is it inside a loop?
remove the optional ? from the route in wep.php and change the route statement to use null coalesce
<a href="{{route('success_details',['locale' => app()->getLocale(), 'slug' => $story->slug ?? 'no-slug-here'])}}" class="read-more">Read More</a>
Then advise the behaviour you see
1 like
Level 1
I changed it as you suggested, but This back us to the same error
Level 21
Hi @manof360, Please check the second technique from this video https://laracasts.com/series/laravel-6-from-scratch/episodes/26
Work step by step, ensuring slug is returned properly and then the locale
Level 1
dear friend : @martal .. I ma sorry I late . the output of logger('Slug is', [$slug]); is :
[2019-12-15 11:24:12] local.DEBUG: Slug is ["domind-in-the-stone-of-muntinte"]
Level 21
You pass 2 parameters (slug and locale) to the url, and your route has only slug.
So you probably have to do this:
Route::get('success','HomPageController@success')->name('success'); Route::get('success/{slug}/{locale}','HomPageController@success_details')->name('success_details');
And also pass $locale into your success_details() method.
Level 1
Hi @maracaibo , I am already hit the right data with the slug and I get the details of story from the database , the problem comes when the laravel want to show the story details in views .... when I make dd() for every line it's work fine, every thing work fine till this line :
return view('user.stories_details', compact('story'));
the error show up
Level 1
@maracaibo I have prefix for the locale parameter
Route::group(['prefix' => '{locale}', 'where' => ['locale' => 'en|fr|ar'],'middleware' => 'setlocale'],function (){
Route::get('success','HomPageController@success')->name('success');
Route::get('success/{slug?}','HomPageController@success_details')->name('success_details');
});
Please or to participate in this conversation.