Level 60
what does not working mean?
Oct 17, 2020
29
Level 4
laravel update() function not working
Class
protected $fillable = [
'mobile_number',
'method',
'tracking_number',
'amount',
'user_id',
'total',
'approved'
];
Controller
public function updateSavings(Request $request) {
$request->validate([
'mobile_number' => 'required',
'method' => 'required',
'tracking_number' => 'required',
'amount' => 'required',
]);
$savings = new SavingAcount();
$savings->mobile_number = $request->mobile_number;
$savings->method = $request->method;
$savings->tracking_number = $request->tracking_number;
$savings->amount = $request->amount;
$savings->total = $request->total;
$savings->user_id = $request->id;
$savings->approved = 1;
$savings->update();
return redirect('/admin/savings')->with('status', 'savings Updated');
}
Level 4
Amount is not updating
Level 60
public function updateSavings(Request $request) {
dd($request->all());
}
everything shows up here? amount, method and so on? you may have validation errors, and you are redirected back
Level 4
everythings there
Level 104
Why are you newing up an instance and then calling update on it; it doesn't exist. You need to save, not update if the rest of the logic is correct, meaning you intend to create a new record in the database.
1 like
Level 4
when i save this. it makes new record. But I want to update
Level 104
But you do nothing to retrieve the record from that database that you want to update. How do you pass the id of the SavingAccount record to the updateSavings method?
Level 4
By routing
Level 104
In that case you should type hint a property on the method that matches the wildcard on the route definition, e.g.
public function updateSavings(Request $request, SavingAccount $savingAccount) {
//...
No new needed
Level 4
But it shows Exception
Level 104
What is the Exception?
Level 4
Still not updating
Level 4
I solved that. But still not updating
Level 104
Can you show the full controller method as it is now?
Level 4
Even cut the validation code
public function updateSavings(Request $request, SavingAcount $savings) {
$savings->mobile_number = $request->mobile_number;
$savings->method = $request->method;
$savings->tracking_number = $request->tracking_number;
$savings->amount = $request->amount;
$savings->total = $request->total;
$savings->user_id = $request->id;
$savings->approved = 1;
$savings->update();
return redirect('/admin/savings')->with('status', 'savings Updated');
}
Level 75
Did you read documentation?
Level 104
Use save not update; the update method takes an array of attributes
Level 4
i know. But save method making new record instead of updating
Level 104
In that case you have not understood earlier when I said that the typehinted argument must match the route wildcard. Show the route
Level 4
Route::put('/admin/savings/update/{user_id}/{total}', 'AdminController@updateSavings');
Level 104
You have a user_id and total as wildcards, that are unused in the controller action arguments?!! What are you doing???
Take a look at the docs for routing for goodness sake.
Level 4
I am using it on the controller
Level 104
You must to pass the information necessary to identify the SavingAccount model!!! Anything else is form data
Level 75
Where?!
Level 4
$savings->mobile_number = $request->mobile_number;
$savings->method = $request->method;
$savings->tracking_number = $request->tracking_number;
$savings->amount = $request->amount;
$savings->total = $request->total;
$savings->user_id = $request->user_id;
$savings->approved = 1;
$savings->save();
on total and user_id. It comes from wildcard. this is not form data...
Level 104
Is Laravel supposed to guess the correct SavingAccount? You said you were getting the SavingAccount model from routing, you are not. If the User has just one SavingAccount associated then get it through the relationship
Level 4
Thank you so much. I fixed the issue..
Level 104
🤷♂️
Level 4
what.. can't understand
Please or to participate in this conversation.