Level 1
I have tried this and it does not work
Apr 4, 2020
47
Level 1
Laravel: Undefined variable: posts (View: (frustrating)
So i have a problem that has been bugging me for a few days now. I want to display my posts on my homepage that is already displaying on my other pages. I think i have found why the information is not displaying and this is due to the Routes of the page. The view is looking fine and works correctly, however my controllers are the issue:
Web.php
Route::get('/', 'PageController@index');
Route::resource('postings', 'HomeController');
HomeController.php
public function __construct()
{
$this->middleware('auth');
}
public function index()
{
$postings = Post::all();
return view('Pages.welcome', compact('postings'));
}
}
Welcome.blade.php
@if(isset($postings) && count($postings) > 1)
@foreach($postings as $post)
<h2><a href="/posts/{{$post->id}}">{{$post->title}}</a></h2>
@endforeach
@else
</p>no posts found</p>
@endif
The issue is in my WEB.PHP. PageController@index directs the page to the homepage, with HomeController being the controller that holds index. I then decided to create a function within that HomeController that allows me to display posts, however i keep getting error 'undefined error'. To conclude how would i insert a function in an existing controller that already has index.
Level 122
We had this a week ago?
Your web.php is using two controllers PageController and HomeController
Which is it you are trying to fix?
What do you mean by 'homepage'
Level 1
yes your back, so i kinda clocked the issue i was having which was the two controllers used for the one page. I am going to update my answer as i have partly solved the issue. I can get the undefined variable error to disappear but i now receive the error where it is showing no posts even though i have 4 posts in my database. I will update my answer now
Level 122
Were you updating your question?
From what I see.
You have a route / which goes to the PagesController (not shown)
You have a route /welcome which goes to the index1 method on the HomeController.
This controller gets the posts (as $postings)and renders the welcome view.
The welcome view iterates over the posts.
Thats it.
Pages controller is not relevant to the question
The / route is not relevant to the question.
So, when you visit /welcome you see the posts?
Level 1
The question has now updated. I removed the /welcome route as i'm now using the /postings route. Now when i get to the /welcome i see no posts, the message 'no posts found' appears which was hard coded in if there are no posts.
However i have 4 posts in my database but none are appearing.
Level 122
Now when i get to the /welcome i see no posts,
you will only see the posts when you go to the /postings route
Level 1
but postings is grabbing a resource right ? i have other routes like that of postings which follow the same kind of structure, why wont i see the posts and how could i potentially fix it ?
Level 122
You should see the posts when you go to /postings.
WHY would you see the posts when you go to /welcome
Level 122
Whats your point?
The route postings is named postings.index and routes to HomeController@index
Level 1
I have no page called postings, its just a variable within the index method that is in my HomeController. I have done the same for another page where i grab the variable posts using the route: Route::resource('posts', 'PostsController');
Level 1
but that should display my data postings right ?
Level 122
We have an expression 'the penny will drop in a moment'
MVC applications don't have 'pages' Although they appear to have.
They have a front-end router. This looks what you are asking for and directs you to a controller that can take care of it for you.
postings goes to HomeController. It can use a view called welcome.blade.php or anything.blade.php. There is ZERO relationship between the name of the view file and the route that you hit with your browser.
Level 1
so how will i exactly create that relationship between my view (welcome.blade.php) and route (HomeController.php). Are you saying get rid of the postings route and use something say /welcome ?
Level 122
what do you want to do?
Use concrete terms not like "show posts on my home page"
Level 1
I want to fetch the posts from my Database onto my view (Welcome.blade.php). My controller HomeController.php is set with an index function that fetches the data. However i cant get my posts to display on the page.
Now how would i set up a route for that ?
Level 122
WHAT ROUTE??????
Level 122
ok, I'll just advise
HomeController
public function index()
{
$postings = Post::all();
return view('Pages.welcome', compact('postings'));
}
welcome.blade.php
@forelse($postings as $post)
<h2><a href="/posts/{{$post->id}}">{{$post->title}}</a></h2>
@empty
</p>no posts found</p>
@endforelse
Route
Route::get('/', 'HomeController@index')
or
Route::get('welcome', 'HomeController@index')
or
Route::get('postings', 'HomeController@index')
or
Route::get('anythingwhatever', 'HomeController@index')
Level 17
Just show us github repository and we will find your mistakes
Level 1
i still get the same issue as i did previously with the undefined variable postings when i use the recommended code
Level 1
Hi @keizah I will upload my code to github soon
Level 122
are you sure you are editing resources/views/Pages/welcome.blade.php
Level 1
100% yes i am. is there a way you can see my whole project, i guess if i load it to github you may get a better understanding of the code right ?
Level 122
right
Level 1
https://github.com/karanjitsahota/FYP.git
Resources-> views -> Pages you should see welcome.blade
Level 75
I would recommend watching some more from scratch videos, Jeffrey covers basic crud.
You just need to set up a correct route to load the correct view.
Level 54
@kdotsmith Why do you have all of this duplication at the bottom of your routes/ web.php file.
Auth::routes();
Route::get('/home', 'HomeController@index')->name('home');
Auth::routes();
Route::get('/home', 'HomeController@index')->name('home');
Auth::routes();
Route::get('/home', 'HomeController@index')->name('home');
Auth::routes();
Route::get('/home', 'HomeController@index')->name('home');
Auth::routes();
Route::get('/home', 'HomeController@index')->name('home');
Level 1
okay, i did not seee that, i think that may have been done accidentally today, i will remove it now
1 like
Level 22
if we can see a screenshot of the error , please
1 like
Level 122
still, the same issues.
Route::get('/', 'PageController@index');
page controller
class PageController extends Controller
{
public function index() {
return view('pages.welcome');
}
So the route / goes to page controller, which returns the welcome view, but does not initialise the $postings variable.
meanwhile /postings probably works fine.
Also, be MORE careful with the names for things. On some operating systems resources/views/Pages is not the same as resources/views/pages but you seem to use the two without much care
Level 75
A post such as this should not be a tutorial. And, until you take a decent or a basic tutorial on basic crud you will continue to have these types of questions.
At least have a look at https://www.sitepoint.com/crud-create-read-update-delete-laravel-app/
If only you would view some of those free videos Jeffrey explains these basics.
Please or to participate in this conversation.