Level 10
May 29, 2017
7
Level 28
Laravel Issues are getting closed too loosely
As a community I am passionate about, I feel I must speak up here. If you find a bug in Laravel, the community contributors are jumping on it and closing them, without actually testing the issue you are reporting.
This has now happend to me several times this month, and most recently today (https://github.com/laravel/framework/issues/19394). I know what the expected behaviour of this issue was, so I knew it was a bug. They closed the issue marking it as "expected behaviour", when I was actually trying to tell them it wasn't doing that.
A few weeks ago I posted about an Event testing issue. I even went as far as to make a public repo to demonstrate how the Event::fake() wasn't working 100% as expected. Everyone commented, saying I must be doing something wrong, and eventually closed the issue. Without any code changes, it started working again in the next Laravel update, so it clearly was a bug.
Taylor holds his code to a very high standard, and I have applauded him for it. Maybe we should hold the people that have the power to close these issues, to a higher standard as well.
Level 122
on this occasion I have to side with the mods. min has always been the minimum numeric value and not the length.
Sounds like what you want is a new rule since the current one cannot be modified as people will be relying on it working the way it does. For instance if I allow a user to set a value but only between 20 and 49 then min:20|max:49 would be my rule
I would be pissed if this was changed to mean that my number can be between 20 and 49 digits long
This particular rule is confusing though since when dealing with strings, it does check the length.
If you don't need to support negative values then min:10000 should work for you?
put in a pull request for min_digits or max_digits if you think it's needed?
definitely not a bug though
Level 75
This is kind of nonsense since MySQL and other databases handle this stuff already not to mention PHP. It's not that big of a deal to create custom rules.
Level 122
@chrisblackwell that's not to say that I don't hear you.
It seem sometimes that the issues list is like a game of tower defence. Your claim has to be pretty watertight to get serious consideration. I can only assume that this is an attitude developed from dealing with thousands of badly informed claims.
@jlrdw .. random as ever..
Level 75
@Snapey issue #19394 would not make sense anywhere in the universe not even a parallel universe. OP seriously learn how to write some custom validation for yourself are you a developer or expect Taylor do everything for you?
This kind of question is a very scary thing.
Level 13
@chrisblackwell Hi. Zip Codes (U.S. ???) are Strings with at least a minimum size of 5 and each each character is limited to values 0 through 9. You have to to validate this one on your own. SQL could care less and 'OR'ing together 'RULES' (Unless documented) is useless. The maintainers could point that out. Remember, no framework is magic. Custom validation rule applies.
Level 75
When dealing with zip codes you could actually validate that rather quickly with some simple JavaScript. But wait Taylor is supposed to add anything and everything everyone possibly wants.
Please or to participate in this conversation.