Laravel groupBy query (API Resource)

Isnt this more or less the same as you did here?

https://laracasts.com/discuss/channels/laravel/property-academic-id-does-not-exist-on-this-collection-instance

@sinnbeck No that is for time table. that is working fine. This is for student marks, In this I am not getting the data in the above format

But you are again trying to groupBy on the data before sending in into the resource. That is the same issue as before

$marks = StudentMarksResource::collection(StudentsMark::whereIn('academic_id',$ids)
->whereIn('student_id',$studentid)->get()->groupBy('exam_type'));

@sinnbeck I have tried this also. how you have told me yesterday

     ```    $marks = DB::table('students_marks')
         ->whereIn('academic_id',$ids)
         ->whereIn('student_id',$studentid)
         ->get()->groupBy('exam_type')->map(function($group){
             return StudentMarksResource::collection($group);
         });```

I have been thinking but I dont see any clever way of doing this, as it kinda breaks how an api resource works.

This is untested buy try something like this and see what you get

 public function toArray($request)
   {
       foreach ($this as $item) {
            $data[]['details'] =  [
           
           'exam_type' => $titemis->exam_type,
           'class_id' => Course::find($item->class_id),
           'batch_id' => Batch::find($item->batch_id),
           'student_id' => Student::find($item->student_id),
           'subject' => $item->subject,
           'marks' => $item->marks,
           'marksgrade' => $item->marksgrade,
           'total' => $item->total,
           'grade' => $item->grade,
           'percentage' => $item->percentage,
           'year' => $item->year,
           
       ];
       }
       return $data;
   }

$marks = DB::table('students_marks')
         ->whereIn('academic_id',$ids)
         ->whereIn('student_id',$studentid)
         ->get()
    ->map(
        // here you return new StudentResource($student) or what ever you named resource and model/variable
    )
    ->groupBy(
        // then you group by the desired prop, not sure does your resource collection has any specific data on it
    );

Or also you can return without grouping and then just group it on the front end. You should return your resources to be as plain as possible so you can reuse them. If the presentation layer of your app requires grouping then group it there.

@bugsysha thank for replying I will try this and let you know

@matheenulla sure thing. Point is that by grouping something you will probably need that only in one place. But without grouping you can use it at multiple places. Like having orders. If you want to group them per day then probably that is just one place in the app, while showing them one by one which you normally do in your index controller method will be usable in many shapes and forms. Like many programmers tend to group things while they need filtering.

Hope it makes sense.

@bugsysha @sinnbeck I have one small doubt. I am totally new to this API and I don't know how they will build mobile apps using API. My Doubt is, we need to create API how a mobile app developer will say? or we just need to give API and rest of the things they will do? .

There is almost always some kind of transformation which you do on the device which receives response from API so do not worry about it. But if you have unreasonable people around you then there is nothing you can do but to group them.

If that is the case then I think my first reply should work.

@bugsysha I tried that one I am getting an error Call to undefined method stdClass::first()

$marks = DB::table('students_marks')
        ->whereIn('academic_id',$ids)
        ->whereIn('student_id',$studentid)
        ->get()
        ->map(function($group){
            StudentMarksResource::collection($group);

          })
        ->groupBy('exam_type');

Maybe cause you haven't returned anything from your map().

return StudentMarksResource::collection($group);

And are you sure that you get something that you should name $group as a parameter in a callback in map? It should be single stdObject instance of $studentMark.

@sinnbeck @bugsysha finally the exact output what I want that I am getting now. Thank you very very very much for helping me. I was suffering this from last 2 days thank you once again

@sinnbeck @bugsysha I have made changes like this

 $exam_types = StudentsMark::whereIn('academic_id',$ids)->whereIn('student_id',$studentid)->distinct()->get(['exam_type','academic_id','student_id']);

       $marks = StudentMarksResource::collection($exam_types);

resource file is

public function toArray($request)

{    
    return [

        'exam_type' => $this->exam_type,
        'details' => StudentMarks::where('academic_id', $this->academic_id)
        ->where('student_id', $this->student_id)
        ->where('exam_type',$this->exam_type)
        ->get(),

    ];
}

thank you once again

You are very welcome. Glad you solved it. Now go and listen to some Jimi Hendrix to relax 🙂

@bugsysha 😂😂😂😂