Laravel DDD Repositoty code with image

I used DDD style code in my project. but I confuse to upload an image with repository code DDD this is what my repository code looks like

    protected function createReimbuseStub($input)
    {
        $carpool_reimbuse = self::MODEL;
        
        $carpool_reimbuse = new $carpool_reimbuse();
        $carpool_reimbuse->uuid = utf8_encode(Uuid::generate(4));
        $carpool_reimbuse->user_id = 1;
        $carpool_reimbuse->transaction_id = 1;
        $carpool_reimbuse->type = $input['type'];
        $carpool_reimbuse->price = $input['price'];

        if ($request->hasFile('file')) {
            $file[] = $request->file('file');

            foreach ($file as $file_docs) {
                $name = time();
                $extension = $file_docs->getClientOriginalName();
                $newName = $name . '-' . $extension;
    
                $size = $file_docs->getSize();
            
                Storage::putFileAs('public', $file_docs, $newName);
                
                $data = [
                    'path' => 'storage/app/public/' . $newName,
                    'size' => $size
                ];
    
                $carpool_reimbuse->image = $newName;    
            }
        }

        return $carpool_reimbuse;
    }

swarley_HIMYM

4 years ago

Level 1

and a got error like this

ErrorException
Undefined variable: request

after I add the Request $request to the parameter still get the error but a different error, like this

Symfony\Component\Debug\Exception\FatalThrowableError
Argument 1 passed to Domain\Carpool\Repositories\CarpoolRepo\carpoolReimbuseRepository::createReimbuseStub() must be an instance of Illuminate\Http\Request, array given, called in /opt/lampp/htdocs/carpool/app/domain/Carpool/Repositories/CarpoolRepo/carpoolReimbuseRepository.php on line 39

martinbean

4 years ago

Best Answer

Level 80

@rully You don’t seem to be following the principles of Domain-Driven Design properly. I’m not sure what’s going on with that repository name (Domain\Carpool\Repositories\CarpoolRepo\carpoolReimbuseRepository seems far too long and nested in too many levels); and your domain layer should know nothing about the application layer, so you shouldn’t be getting errors about expecting instances of Illuminate\Http\Request classes. Requests are an application layer concern; not a domain-layer concern.

In DDD, repositories are used to fetch data, and services are for domain operations (i.e. actions that will end up creating/updating/deleting entities). So you should have a service that creates a reimburse stub (whatever that entity is). That service should also receive pre-validated data and not a HTTP request instance.

If you want to enforce the data that is passed to the service (which is by no means a bad thing at all), then you can use a DTO (data transfer object). This is a class that can only be instantiated with good data, and then you would pass an instance of this DTO class to your service class method. Your service class can then access the data in the DTO, knowing it’s already been validated and is “good”; your service class will no longer need to do any checking of its own any more. Your application layer will then transform input (HTTP request body, console command arguments/options, etc) into an instance of the relevant DTO, and then pass that DTO to your service class in the domain layer:

public function store(StoreReimburseStubRequest $request)
{
    // Convert request data to DTO
    $dto = CreateReimburseStubDto::fromRequest($request);

    // Pass DTO to service class method and create new entity
    $reimburseStub = $this->reimburseStubs->create($dto);

    // Return some sort of response to client
}

Your domain layer is now completely isolated from the application layer.

Please or to participate in this conversation.