Level 102
Dont call controllers from a schedule. Controllers are for http calls only. Instead put the logic into a job, and call that from both places (If the logic is identical)
Sep 2, 2022
8
Level 1
Laravel 9 - task scheduler controller function
Hello i'm looking on how to execute a controller function with a cronjob. I've read the documentation but it doesn't explain on how to call a controller function.
I have this function:
function oracle(Request $request) {
// some get-insert statements using DB Facade
}
Let's say i want to run this function every 10 minutes for each db record that has status = 0
then in laravel scheduler something like:
$schedule->call(function () {
//.. DB query to check all orders that have status = 0
//.. for each record that returns 0
//.. execute oracle()
}
})->everyMinute();
Basically all orders with status 0 are on mysql, now the oracle() logic triggers on a manual click. This function gets data from mysql and inserts to the oracle database. Once the record is on oracle it returns status 1 to mysql. I have to do this with a cron.
Which way should i go for?
Level 1
@Sinnbeck maybe it's not the best practice, but i created a command and insert the controller's logic in the handle() method. Everything seems working fine! Thank you so much!
Level 102
@shaddark I assume you just copy pasted the code? That's totally fine :)
1 like
Level 1
@Sinnbeck Yes i copy pasted and only removed the return status messages
Level 102
@shaddark Great. Personally I use actions: https://freek.dev/1371-refactoring-to-actions
1 like
Level 1
@Sinnbeck thanks a lot!
Level 25
To avoid repeating the same code all over, you could create a service class with a method called ‘oracle()’ and then do what you need to do in there
Then in controller and command you could do
// controller
public function oracle(Request $request)
{
resolve(YourService::class)->oracle();
// rest of your code here
}
// command
public function handle(YourService $yourService)
{
$yourService->oracle();
}
Level 1
@thugic i will consider this way for avoid code repetition, thanks!
1 like
Please or to participate in this conversation.