Laravel 5.3 - Using Mailable inside a Notification

+1

Thank you! It did help me, it was EXACTLY what I was experiencing, and finding this resolved it.

+1 !!!!

Thanks! I was assuming that a mailable should work via notification and I was scratching my head to find out why it wasn't sending the mail.

Could you show your code in the Notification toMail() method for returning a Mailable class?

Sure. Here is a very basic example.

Notification:

class UserRegistered extends Notification {
    use Queueable;
    
    protected $user;
    
    public function __construct(User $user) {
        $this->user = $user;
    }
    
    public function toMail($notifiable) {
        return new \Core\Mail\UserRegistered($this->user);
    }
}

Mailable:

class UserRegistered extends Mailable {
    
    /**
     * @var User
     */
    protected $user;
    
    public function __construct(User $user) {
        $this->user = $user;
    }
    
    /**
     * Build the message.
     *
     * @return $this
     */
    public function build() {
        
        $this->to($this->user->email);
        
        return $this->view('emails.user_registered');
    }
}

Calling it in the controller:

$user->notify(new UserRegistered($user));

Hey cool, thanks for that, I ran into the same problem and had to dig into the source code to come out with (approx.) the same conclusion.

Quick note

Passing $user down to your Mailable instance defies the purpose of Notifications.

A better approach is to pass the to param inside the Notification class itself, in the toMail method:

class UserRegistered extends Notification {
    ...

    public function toMail($notifiable)
    {
        $mail = new \Core\Mail\UserRegistered();
        $mail->to($notifiable->email);

        return $mail;
    }
}

Right, I actually considered adding after that that in most cases, the notifiable variable would be better to use instead.

I pulled this from an example that I had to do some extensive logic in determining which (of multiple) emails and phone numbers to use, in which case I did the logic to determine which email in the Mailable class, but that could still be done in toMail()

thanks! it helped

I stumbled here too, and decided to make a custom MailableChannel that implements the behaviour I expected, this allowed my mail notifications to be consistent with others I already have

class MailableChannel extends MailChannel
{
    /**
     * Send the given notification, but unlike MailChannel, set the to address on Mailables
     *
     * @param  mixed  $notifiable
     * @param  \Illuminate\Notifications\Notification  $notification
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        if (!$to = $notifiable->routeNotificationFor(self::class, $notification)) {
            return;
        }

        return $notification->toMailable($notifiable)->to($to)->send($this->mailer);
    }
}

Hello and thank you for this solution.

I am actually using Laravel 6.7 and the problem was still there and I had to fix it your way !

But I plan to upgrade to Laravel 8.x, has this bug been fixed ? Should I change the code once upgraded ?

Thank you !

For anyone still looking for a solution, I found the cleanest way to be:

public function toMail($notifiable)
{
    return (new OrderSubmitted())->to($notifiable->routeNotificationFor('mail', self::class)));
}

After much struggling with the above... I managed to the mail to send by setting the ->to

$mail->to($notifiable);