Increment Invoice no

If the query yields no results the variable is null, so you can just do

if (! $label_ID) {
	//assign the new one
} else {
	// Assign the existing one
}

Hi there,

Let's see how we can refactor this piece of code to make it more readable:

public function getlabel_ID(): string {
	// Change to the var naming as we are not only selecting "label_ID" but rather the entire model object.
	$matchingIncomingGetWeight = IncomingGetweight::where('label_ID', '<>', "")->orderBy('id', 'desc')->first();
	
	// Move the logic to its own function to keep the main function readable.
	return $this->buildStringNumber(Carbon::now(), $matchingIncomingGetWeight);
}

private function buildStringNumber(Carbon $date, IncomingGetweight $incomingGetWeight = null): string {
	// Now we can just directly return the value if $incomingGetWeight isn't null
	if (null !== $incomingGetWeight) {
		return $incomingGetWeight->code."-".$date->('ymd)."-"."001";
	}

	// Combine the seperated creation of a new number.
	$newNumber = ((int) substr($incomingGetWeight->label_ID, 9, 3)) + 1;

	// Directly return rather than also putting it into a var.
	// Do note that the 2nd param in str_pad sets the length: We substr with a 
	// length of 3 And you want to add 2 "0" before this, 
	// so in total we need a length of 5.
    return $label_ID->code."-".$date."-".str_pad($newNumber, 5, '0', STR_PAD_LEFT);
}

Hope this helps a bit.