Custom validation translations

public function postAdd(Request $request) {

   $messages = [
                    'name.required'     => 'Please enter your name',
                    'email.required'    => 'Please enter your email',
                    'email.email'       => 'Please enter a valid email address',
                    'email.unique'      => 'Email has been register',
                    'password.required' => 'Please enter your password',
                    'password.same'     => 'Password and repassword not match',
                    'phone.required'    => 'Please enter your phone',
                    'phone.numeric'     => 'Please enter your phone number format',
                    'birthday.required' => 'Please enter your birthday',
                    'position.not_in'   =>'Please select position',
                    'level.not_in'      =>'Please select level',
                    'department.not_in' =>'Please select department'
                ];
    $validator       = Validator::make($request->all(), [
        'name'       => 'required',
        'email'      => 'required|email|unique:staff,email',
        'password'   => 'required|same:repassword',
        'phone'      => 'required|numeric',
        'birthday'   => 'required',
        'position'   =>'not_in:0',
        'level'      =>'not_in:0',
        'department' =>'not_in:0'
    ],$messages);

    if ($validator->fails()) {
        return redirect('staff/add')
                    ->withErrors($validator)
                    ->withInput();
    }else{
    //do some thing 
  }

}

Hi @nhan,

Nice try, but wide of the mark I'm afraid.

What I need is a way to replace the entire validation translations file:

• https://github.com/laravel/laravel/blob/master/resources/lang/en/validation.php#L16-L81

As mentioned, I've now achieved this by extending the Validator class, loading my own translations:

class CrudValidator extends Validator
{
    public function __construct(array $data, array $rules)
    {
        /**  @var Translator $trans */
        $trans  = \App::make('translator');
        $trans->load('crud', 'validation', App::getLocale());

        // parent
        parent::__construct($trans, $data, $rules);
    }

And overriding:

• getMessage()
• getSizeMessage()

Both now tack on the package namespace to return the correct translation:

• https://github.com/laravel/framework/blob/5.2/src/Illuminate/Validation/Validator.php#L1771

$key = "crud::validation.{$lowerRule}";

I think this could also be achieved by passing a custom LoaderInterface into a Translator which would load the package [crud] translations into the default [*] translations namespace:

Illuminate\Translation\Translator Object
(
   ...
    [loaded:protected] => Array
        (
            [crud] => Array <-- WOULD SET THE [*] KEY INSTEAD
                (
                    [validation] => Array
                        (
                            [en] => Array
                                (
                                    [accepted] => This field must be accepted.
                                    [active_url] => This field is not a valid URL.

But that then begins to feel like a horrible hack.

Any more insight into this problem is welcome.

I think you should register a custom validator :

$this->app['validator']->resolver(function ($translator, $data, $rules, $messages, $attributes) {

    // set $translator or $messages or $attributes accordingly here (dont know exactly what to do here but those vars are injected in the validator here)

    return new Validator($translator, $data, $rules, $messages, $attributes);

});

Thanks @pmall - yeah, I tried this before, and the validator throws an error when it comes to array properties of the format:

    "min" =>
    [
        "numeric"           => "This field must be at least :min.",
        "file"              => "This field must be at least :min kilobytes.",
        "string"            => "This field must be at least :min characters.",
        "array"             => "This field must have at least :min items.",
    ],

I tried converting these to dot.properties but no luck.

I'll try again though - I've been through this a dozen times now, and my understanding of the underlying architecture has improved dramatically as a result - maybe I'll hit upon the right formula.

Double check this because seems to me the cleanest way of doing what you want. Don't you get some info by dd($messages) ?

I agree! The documentation says as much which why I was really surprised it errors.

OK, here's one of my test code functions:

public function messages3()
{
    // input
    $input      = ['name' => 'dave'];
    $rules      = ['name' => 'required|min:30'];
    $messages   = [
        "required"    => "This field is required.",
        "min"         => [
            "numeric" => "This field must be at least :min.",
            "file"    => "This field must be at least :min kilobytes.",
            "string"  => "This field must be at least :min characters.",
            "array"   => "This field must have at least :min items.",
        ],
    ];

    /** @var \Illuminate\Validation\Validator $valid */
    $valid  = \Validator::make($input, $rules, $messages);

    // errors
    pr($valid->errors()->first('name'));
}

And here's the error:

Clearly MessageBag does not like being handed an array.

• Maybe this is where I should be concentrating my efforts
• Think this could be a bug in how Validator handles "size" messages.

Will start looking into it, then as you say, I can just pass in custom messages and not have to muck about with everything I'm going above

OK, looks like a bug with "inline" (seems to be the vocab used internally for custom) validation messages.

Which can be fixed with the following:

    /**
     * Get the inline message for a rule if it exists.
     *
     * @param  string  $attribute
     * @param  string  $lowerRule
     * @param  array   $source
     * @return string
     */
    protected function getInlineMessage($attribute, $lowerRule, $source = null)
    {
        $source = $source ?: $this->customMessages;

        $keys = array("{$attribute}.{$lowerRule}", $lowerRule);

        // First we will check for a custom message for an attribute specific rule
        // message for the fields, then we will check for a general custom line
        // that is not attribute specific. If we find either we'll return it.
        foreach ($keys as $key)
        {
            if (isset($source[$key]))
            {
                $message = $source[$key];
                // FIX
                if(is_array($message))
                {
                    $type = $this->getAttributeType($attribute);
                    return $message[$type];
                }
                return $message;
            }
        }
    }

I'll test this out and submit a PR if it appears to work.

Thanks @pmall for prompting me to look again at custom validation messages :)