Sep 14, 2024

Level 5

Contactus form is not working

Hi all,

I don't know where the bug comes from, as it sometimes works and sometimes not, i put return $request in sendContact method before it gets submitted it also sometimes it return data and sometimes can't catch nothing,

in sendContact method

  public function sendContact(ContactUSRequest $request){
        //return $request;
        //print_r($request) ;
        //dump($request);
         try {


        $contact = new ContactUS();
        $details =[
            'name' => $request->name,
            'telephone' => $request->telephone,
            'subject' => $request->subject,
            'message' => $request->message,
            'email' => $request->email,
        ];

        $contact->name = $request->name;
        $contact->email = $request->email;
        $contact->telephone = $request->telephone;
        $contact->message = $request->message;
        $contact->subject = $request->subject;
        $contact->save();

        //Mail::to('[email protected]')->send(new ContactMail($details)); //use this when in production
    return back()->with(['success'=>trans('front/contactus.Your message has been sent successfully')]);
        } catch (\Throwable $th) {
            return redirect()->back()->with(['error' =>  trans('front/contactus.Your message has been not sent')]);
        }
    }

in blade

  <form action="{{ route('send.message') }}" method="POST" enctype="multipart/form-data" novalidate id="contactForm">
                    @csrf   

                    <h2 class="">{{ trans('front/contactus.Let\'s talk') }}...!</h2>
 
                    <div class="row mt-4">

                        <div class="col-lg-6">
                            <div class="form-group">
                                <label>
                                    <i class="icofont-user-alt-3"></i>
                                </label>
                                <input type="text" name="name" id="name" class="form-control" placeholder="{{ trans('front/contactus.Name') }}" required data-error="Please enter your name">
                                <div class="help-block with-errors"></div>
                            </div>
                            @error('name')
                            <span class="text-danger">{{ $message }}</span>
                            @enderror
                        </div>

                        <div class="col-lg-6">
                            <div class="form-group">
                                <label>
                                    <i class="icofont-ui-email"></i>
                                </label>
                                <input type="text" name="email" id="email" class="form-control" placeholder="{{ trans('front/contactus.Email') }}" required data-error="Please enter your email">
                                <div class="help-block with-errors"></div>
                            </div>
                            @error('email')
                            <span class="text-danger">{{ $message }}</span>
                            @enderror
                        </div>

                        <div class="col-lg-6">
                            <div class="form-group">
                                <label>
                                    <i class="icofont-ui-call"></i>
                                </label>
                                <input type="text" name="telephone" id="phone_number" placeholder="{{ trans('front/contactus.Telephone') }}" required data-error="Please enter your number" class="form-control">
                                <div class="help-block with-errors"></div>
                            </div>
                            @error('telephone')
                            <span class="text-danger">{{ $message }}</span>
                            @enderror
                        </div>

                        <div class="col-lg-6">
                            <div class="form-group">
                                <label>
                                    <i class="icofont-notepad"></i>
                                </label>
                                <input type="text" name="subject" id="msg_subject" class="form-control" placeholder="{{ trans('front/contactus.Subject') }}" required data-error="Please enter your subject">
                                <div class="help-block with-errors"></div>
                            </div>
                            @error('subject')
                            <span class="text-danger">{{ $message }}</span>
                            @enderror
                        </div>

                        <div class="col-lg-12">
                            <div class="form-group">
                                <label>
                                    <i class="icofont-comment"></i>
                                </label>
                                <textarea name="message" class="form-control" id="message" cols="30" rows="8" placeholder="{{ trans('front/contactus.Write message') }}" required data-error="Write your message"></textarea>
                                <div class="help-block with-errors"></div>
                            </div>
                            @error('message')
                            <span class="text-danger">{{ $message }}</span>
                            @enderror
                        </div>

                        <div class="col-lg-12">
                            <button type="submit" class="btn common-btn">
                                {{ trans('front/contactus.Send Message') }}
                            </button>
                            <div id="msgSubmit" class="h3 text-center hidden"></div>
                            <div class="clearfix"></div>
                        </div>
                    </div>

                </form>

Any idea to get this working without bugs ? Many thanks

tykus

1 year ago

Level 104

sometimes works and sometimes not

Can you please describe what sometimes not means; do you get an error message or white screen of death, or something else? What is the data-error attribute for; do you have some client-side validation also? What does the ContactUSRequest FormRequest class look like?

Aside, your controller is a mess; you can get the $rerquest->validated() data from the FormRequest class and save your self multiple lines of unnecessary code? Also, why do you need a try/catch here; what are you expecting will go wrong?

I think your method can work just as well like this:

public function sendContact(ContactUSRequest $request)
{
    $contact = ContactUS::create($request->validated()); // set fillable/guarded on Model

    Mail::to('[email protected]')->send(new ContactMail($request->validated())); 
    return back()->with(['success'=>trans('front/contactus.Your message has been sent successfully')]);
}

1 like

Zoul

1 year ago

Level 5

Thanks @tykus for your help !

The error i got is The message has already been taken. in red color. when i try to enter a wrong email, phone number or leave empty field, the validation is working correctly

in my ContactUSRequest

class ContactUSRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'name' =>'required',
            'email' => 'required|email',
            'telephone' =>'required',
            'subject' => 'required',
            'message' =>  ['required', 'string', Rule::unique('contactus','message')], 
            
        ];
    }

    public function messages()
    {
        return [
            'name.required' => trans('front/required/contact.name'),
             'email.required' => trans('front/required/contact.email'),
             'telephone.required' => trans('front/required/contact.telephone'),
             'subject.required' => trans('front/required/contact.subject'),
             'message.required' => trans('front/required/contact.message'),
             
        ];
    }
}

The try/catch i uncommented it when i posted here, as you advised no need for it and i just removed it

tykus

1 year ago

Best Answer

Level 104

@Zoul why would the message need to be unique??? That seems like a ridiculous rule to impose

experimentor

1 year ago

Level 25

@Zoul This validation rule

'message' =>  ['required', 'string', Rule::unique('contactus','message')],

Is saying that the message has to be unique.

Assume customer1 posts the contact form with message "I am interested in this" . They will get success response.

After sometime, if customer2 posts the same message: "I am interested in this". They will get error "Message already taken" since your rule says the message has to be unique.

How will customer2 know what customer1 wrote on your website? Please remove this rule. Change it to:

'message' =>  ['required', 'string']

That should be enough.

1 like

Vishal007

1 year ago

Level 1

Define Log Facecase using this

use Exception; // if need use it
use Illuminate\Support\Facades\Log;

public function sendContact(Request $request){
        // use this dd
        dd($request->all);
         try {
        $contact = new ContactUS();
        $contact->name = $request->name;
        $contact->email = $request->email;
        $contact->telephone = $request->telephone;
        $contact->message = $request->message;
        $contact->subject = $request->subject;
        $contact->save();
//check into log
Log::info('data store successfully into database : '.$contact);
//dd here
dd($contact);
        //Mail::to('[email protected]')->send(new ContactMail($details)); //use this when in production
    return back()->with(['success'=>trans('front/contactus.Your message has been sent successfully')]);
        } catch (\Exception $e) {
Log::info('data store successfully into database : '.$e->getMessage);
            return redirect()->back()->with(['error' =>  trans('front/contactus.Your message has been not sent')]);
        }
    }

also check all with dd method to data is posted or not id still issue then please reply

1 like

Vishal007

1 year ago

Level 1

Also Use Validator Using this

use Illuminate\Support\Facades\Validator;

$validator = Validator::make($request->all(), [
            'name' => 'required',
            'email' => 'required',
            // all require parameter add here
        ]);

        if ($validator->fails()) {
            Log::info('validation failed : '.$validator->errors());
            return response()->json([
                'error' => true,
                'message' => $validator->errors()
            ], 422);
        }

1 like

Zoul

1 year ago

Level 5

Thanks @Vishal007 for your help!

I used the code you suggested but neither dd($request->all); or dd($contact); got triggered i see only the error message The message has already been taken. down the form

tykus

1 year ago

Level 104

@Zoul requiring a unique message, why? In any case this is why your form does not submit successfully, it is simply a validation error like any other

Vishal007

1 year ago

Level 1

@Zoul check into database migration the message field you can add unique but this is nothig to need message is not unique if you need then into validation use regex for message field or if message is unique then into validation rule add unique into message field so not get any error and if already then inform first

// also try it
'message' => 'required|message|unique:contactus,message'

1 like

Snapey

1 year ago

Level 122

@Vishal007 message should not be unique in this context.

@zoul listen to @tykus advice

1 like

Jsanwo64

1 year ago

Level 11

also @zoul why is your form having

enctype="multipart/form-data"

Is there a hidden file upload?

1 like

Zoul

1 year ago

Level 5

Thanks @jsanwo64, my form is messed up, so i removed it since no need for a file here

Jsanwo64

1 year ago

Level 11

The error i got is The message has already been taken. in red color. when i try to enter a wrong email, phone number or leave empty field, the validation is working correctly

in my ContactUSRequest

is due to this

            'message' =>  ['required', 'string', Rule::unique('contactus','message')],

Jsanwo64

1 year ago

Level 11

Since it is just a contact form that submits to the DB and sends a mail it should not complicated

try this

use App\Models\ContactUS;
use Illuminate\Support\Facades\Mail;
use App\Mail\ContactMail;

public function sendContact(ContactUSRequest $request)
{
    try {
        // Validate the request using ContactUSRequest, which should have the validation rules
        
        // Prepare data for saving and email
        $contact = new ContactUS();
        $details = [
            'name' => $request->name,
            'telephone' => $request->telephone,
            'subject' => $request->subject,
            'message' => $request->message,
            'email' => $request->email,
        ];

        // Save the contact information to the database
        $contact->name = $details['name'];
        $contact->email = $details['email'];
        $contact->telephone = $details['telephone'];
        $contact->subject = $details['subject'];
        $contact->message = $details['message'];
        $contact->save();

        // Send email notification (uncomment in production)
        // Mail::to('[email protected]')->send(new ContactMail($details));

        // Return back with success message
        return back()->with('success', trans('front/contactus.Your message has been sent successfully'));

    } catch (\Exception $e) {
        // Log the error for debugging purposes
        \Log::error('Contact form error: ' . $e->getMessage());

        // Return back with an error message
        return redirect()->back()->with('error', trans('front/contactus.Your message has not been sent'));
    }
}

N.B: The try and catch is not not necessary, unless you have done something to expect it returning an error.

1 like

Snapey

1 year ago

Level 122

write validated data to the contact model

pass the contact model to the mailable rather than creating separate array

recognise validation errors rather than errors in your controller

1 like

Zoul

1 year ago

Level 5

Thanks @Snapey will apply this

Zoul

1 year ago

Level 5

I remember going through dubplicated message issue when a client submit it once but i got 2, so i implemented this but if we take @experimentor example, it won't just work. Thank alot all of you for your support i really appreciate it

Please or to participate in this conversation.