Complex eloquent query doesn't behave properly

Hello, here is the query:

Topic::with( [ 'user', 'topicCategory', 'tagLanguage', 'tagEnvironment' ] )
     ->when( $selectedLanguageTagIds,  fn( $query ) => $query->whereHas( 'tagLanguage',                                                      fn( $q ) => $q->whereIn( 'id', $selectedLanguageTagIds ) ) )
     ->when( $selectedEnvironmentTagIds, fn( $query ) => $query->orWhereHas( 'tagEnvironment', fn( $q ) => $q->whereIn( 'id', $selectedEnvironmentTagIds ) ) )
     ->when( $CheckArray, fn( $query ) => $query->where( check_topic', '=', 1 ) )
                                                     ->get(),

This query is supposed to return any result that match:

( (tagLanguage OR tagEnvironment) AND CheckArray ) so anything from first or second when querries, AND from those, those that match the forth when query.

What would be the proper way to reformat this query?

tykus

4 years ago

Best Answer

Level 104

Logically grouping the when constraints will give you the expected query:

Topic::with( [ 'user', 'topicCategory', 'tagLanguage', 'tagEnvironment' ] )
    ->where(function ($builder) {
        $builder
            ->when($selectedLanguageTagIds,  fn($query) => $query->whereHas('tagLanguage', fn($q) => $q->whereIn( 'id', $selectedLanguageTagIds)))
            ->when($selectedEnvironmentTagIds, fn($query) => $query->orWhereHas('tagEnvironment', fn($q) => $q->whereIn( 'id', $selectedEnvironmentTagIds)));
    })
    ->when( $CheckArray, fn( $query ) => $query->where('check_topic', '=', 1))
    ->get()

1 like

brakkar

4 years ago

Level 6

@tykus Thanks, smart way!

Please or to participate in this conversation.