204 status code issue in Laravel 11.

return $this->locationInterface->delete('Country', $country->id) ? response(status: 204) : response(status: 500); When I test the api for above delete method in postman, I get the parse error 'Parse Error: The server returned a malformed response'. In Laravel 10, I don't get any issue when I return status cod 204. Is this Laravel 11 issue or what?

s4muel

1 year ago

Level 50

the response(...) AFAIK sets content-type, that might confuse postman to expect/parse some body (just a guess). try replacing it with an abort()

return $this->locationInterface->delete('Country', $country->id) ? abort(204) : abort(500);

and check if that helps

tykus

1 year ago

Level 104

@s4muel abort is not appropriate here; neither is a 500 status code - something in the 4xx range of status codes would be more appropriate

return $this->locationInterface->delete('Country', $country->id) 
    ? response()->noContent() 
    : response()->(['message' => 'your error message'], 400);

1 like

s4muel

1 year ago

Level 50

@tykus agreed, of course, i was blinded by the response(), not thinking about that 👍

and i checked the content-type header to be sure what i thought (and said), i was mistaken anyway 🤦‍♂️

martinbean

1 year ago

Level 80

@yelinnoo Why are you doing this?

return $this->locationInterface->delete('Country', $country->id) ? response(status: 204) : response(status: 500);

If the model is deleted, return the 204 No Content response.

Don’t manually throw 500 errors like that. 500 errors are typically thrown when an exception happens. If you manually return a 500 response like that, you’re going to end up receiving useless errors where a customer reports something’s gone wrong, and you have nothing in your logs.

Please or to participate in this conversation.