Function to check user birth date is 18 years or upper not always work correctly

Hi I am beginner webdeveloper. I use in my project Laravel 5.8. I have this this code:

if ($this->calcutateAge($request->input('date')) < 18) {
            return Redirect::back()->withErrors(['You are a minor. Registration is allowed for adult users']);
        }

function calcutateAge($dob)
    {

        $dob = date("Y-m-d", strtotime($dob));

        $dobObject = new DateTime($dob);
        $nowObject = new DateTime();

        $diff = $dobObject->diff($nowObject);

        return $diff->y;

    }

It's work fine. But I have problem with date ex 2045-12-12. This function is not working. With year: 2015-12-12 - it's okey.

How can I repair it?

Nakov

5 years ago

Level 73

You can do it using Carbon, which has beautiful helper functions:

$date = Carbon\Carbon::parse($request->input('date'));

if ($date->isPast() && $date->diffInYears(now()) < 18)  {
    return Redirect::back()->withErrors(['You are a minor. Registration is allowed for adult users']);
}

Maybe you want to break the above condition, with the check if the date is not in the past to throw a different error back, so the user does not enters dates in future.

2 likes

automica

5 years ago

Level 54

@trifek you'd be best to do this via a custom validation rule, and then you can add a rule in your store method to compare DOB

this is an example in Laravel 5.5 but it should still be valid. http://www.expertphp.in/article/laravel-5-5-new-feature-custom-validation-rules-with-example

trifek

5 years ago

Level 3

It's not help. When I have 2045-12-12 - yours function not working :(

automica

5 years ago

Level 54

@trifek @nakov commented that you'd also need to add something like

if (!$date->isPast())  {
    return Redirect::back()->withErrors(['You have set a date in the future. Registration is allowed for adult users']);
}

Nakov

5 years ago

Best Answer

Level 73

Yeah @trifek read the comments :)

Like @automica solution, but even more readable this way:

if ($date->isFuture())  {
    return Redirect::back()->withErrors(['You have set a date in the future. Registration is allowed for adult users']);
}

automica

5 years ago

Level 54

@nakov adding the ! saved me from checking for the right method name :P

Please or to participate in this conversation.