Level 1
That means User::find($id) did not return a result. You can check that or use FindOrFail()
Dec 8, 2014
28
Level 5
Call to a member function update() on a non-object
I keep getting this error when I try to update my users
Call to a member function update() on a non-object
Here is my edit.blade.php
@extends('templates::admin')
@section('content')
{{ Form::model($users, array('method' => 'PATCH', 'route' =>'admin.users.update', 'route_id'=>$users->id)) }}
<ul>
<li>
{{ Form::label('name', 'Name') }}
{{ Form::text('name', $users->name, array('id' => 'name')) }}
</li>
<li style="display:none;">
{{ Form::label('password', 'Password') }}
{{ Form::text('password', $users->password, array('id' => 'password')) }}
</li>
<li>
{{ Form::label('email', 'Email') }}
{{ Form::text('email', $users->email, array('id' => 'email')) }}
</li>
<li>
{{ Form::submit('Submit', array('class' => 'btn btn-default', 'role' => 'button')) }}
</li>
</ul>
{{ Form::close() }}
@if($errors->any())
<ul>
{{ implode('', $errors->all('<li class="error">:message</li>')) }}
</ul>
@endif
@stop
and here is my UsersController
public function update($id)
{
$input = Input::all();
$validation = Validator::make($input, User::$rules);
if($validation->fails()){
return Redirect::route('admin.users.edit')
->withInput()
->withErrors($validation)
->with('message', 'There were validation errors');
}
if($validation->passes()){
$input['password'] = Hash::make($input['password']);
$users = User::find($id);
$users->update($input);
return View::make('users::index' , $id);
return Redirect::route('admin.users.edit', $id)
->withInput()
->withErrors($validation)
->with('message', 'There were validation errors');
}
}
and this is the line that is giving problems
$users->update($input);
Level 5
I used the FindOrFail() and I got this error
No query results for model [User].
My model is User and it's being called. Here is my User model just in case.
<?php
use Illuminate\Auth\UserTrait;
use Illuminate\Auth\UserInterface;
use Illuminate\Auth\Reminders\RemindableTrait;
use Illuminate\Auth\Reminders\RemindableInterface;
class User extends Eloquent implements UserInterface, RemindableInterface {
use UserTrait, RemindableTrait;
protected $fillable = array('name', 'email', 'password');
protected $guarded = array('id');
/**
* The database table used by the model.
*
* @var string
*/
protected $table = 'users';
/**
* The attributes excluded from the model's JSON form.
*
* @var array
*/
protected $hidden = array('password', 'remember_token');
public static $rules = array(
'name' => 'required',
'email' => 'required',
'password' => 'required'
);
}
I don't understand why this has happend, because it worked fine before. The only difference between now and then is that I'm using creo's module package.
Level 10
It is your route parameter, try this in your Form::model:
'route' => array('admin.users.update', $users->id)
Level 5
I get this error
Route [admin.users.update, $users->id] not defined.
Level 10
check your routes
Level 5
I have
Route::resource('admin/users', 'UsersController');
in my routes.php
and when I type php artisan routes I get
+--------+-----------------------------------+---------------------+---------------------------+----------------+---------------+
| Domain | URI | Name | Action | Before Filters | After Filters |
+--------+-----------------------------------+---------------------+---------------------------+----------------+---------------+
| | GET|HEAD admin/content/pages | | Closure | | |
| | GET|HEAD admin/content/articles | | Closure | | |
| | GET|HEAD admin/content/products | | Closure | | |
| | GET|HEAD admin/content | | Closure | | |
| | GET|HEAD admin/shop | | Closure | | |
| | GET|HEAD admin | | UsersController@showLogin | | |
| | GET|HEAD admin/users | admin.users.index | UsersController@index | | |
| | GET|HEAD admin/users/create | admin.users.create | UsersController@create | | |
| | POST admin/users | admin.users.store | UsersController@store | | |
| | GET|HEAD admin/users/{users} | admin.users.show | UsersController@show | | |
| | GET|HEAD admin/users/{users}/edit | admin.users.edit | UsersController@edit | | |
| | PUT admin/users/{users} | admin.users.update | UsersController@update | | |
| | PATCH admin/users/{users} | | UsersController@update | | |
| | DELETE admin/users/{users} | admin.users.destroy | UsersController@destroy | | |
| | GET|HEAD admin/dashboard | | UsersController@dashboard | | |
| | POST admin | | UsersController@doLogin | | |
| | GET|HEAD / | | Closure | | |
+--------+-----------------------------------+---------------------+---------------------------+----------------+---------------+
Level 52
Check your syntax with this :
Form::model($users, ['route' => ['admin.users.update', $users->id], 'method' => 'patch'])
Level 10
seems good, when i told you to update you form::model I meant this:
{{ Form::model($users, array('method' => 'PATCH', 'route' => array('admin.users.update', $users->id))) }}
Level 5
When I tried both arabsight and bestmomo answeres I got this error
array_merge(): Argument #2 is not an array
I originally had this error to begin with and I got some help to fix it. And that was were I got the error in the beginning of this conversation.
Here is a link to my question http://laravel.io/forum/12-07-2014-array-merge-argument-2-is-not-an-array
Level 52
What is the Laravel version ?
Level 5
laravel 4.2
Level 52
There is something with your Laravel installation. Try a clear-compiled command and a dump-autoloed. If it doesn't work try to start on a fresh installation.
Level 5
ok will do that and get back to you
Level 5
I've installed a new laravel and I've done everything again. And I have this error
No query results for model [User].
which is the same as my post above
Level 10
I replicated your code and its working fine.
where exactly are getting the error.
Level 5
It happens when I update my user. It works fine when I create a new user.
Level 10
try to isolate the problem, check your edit method: is it returning $users variable correctly? if so is your form shown at all?
Level 5
My form does show when I click on the edit button and it gives the correct id in the url. But when I click submit to update I get this in the url
users/%7Busers%7D/edit
Level 65
%7B is an encoded {
Level 10
that's a route param problem, you have to use: 'route' => array('admin.users.update', $users->id)
Level 5
This is what I have in my routes.php
Route::resource('admin/users', 'UsersController');
and this is what my routes looks like in the cmd
+--------+-----------------------------------+---------------------+---------------------------+----------------+---------------+
| Domain | URI | Name | Action | Before Filters | After Filters |
+--------+-----------------------------------+---------------------+---------------------------+----------------+---------------+
| | GET|HEAD admin | | UsersController@showLogin | | |
| | GET|HEAD admin/users | admin.users.index | UsersController@index | | |
| | GET|HEAD admin/users/create | admin.users.create | UsersController@create | | |
| | POST admin/users | admin.users.store | UsersController@store | | |
| | GET|HEAD admin/users/{users} | admin.users.show | UsersController@show | | |
| | GET|HEAD admin/users/{users}/edit | admin.users.edit | UsersController@edit | | |
| | PUT admin/users/{users} | admin.users.update | UsersController@update | | |
| | PATCH admin/users/{users} | | UsersController@update | | |
| | DELETE admin/users/{users} | admin.users.destroy | UsersController@destroy | | |
| | GET|HEAD admin/dashboard | | UsersController@dashboard | | |
| | POST admin | | UsersController@doLogin | | |
| | GET|HEAD / | | Closure | | |
+--------+-----------------------------------+---------------------+---------------------------+----------------+---------------+
Level 5
I changed the route in the form to
'route' => array('admin.users.update', $users->id)
It just went to the index page with out saving anything.
My edit function in my UsersController is
public function edit($id)
{
$users = User::find($id);
if(is_null($users)){
return Redirect::route('admin.users.index');
}
return View::make('users::edit', compact('users'));
}
Level 10
your routes are fine, the problem is in your edit view.
try to write it from scratch and test it step by step.
Level 5
will do. I will get back with whatever I find
Level 5
I have finally fixed my problem. It was so simple I want to cry and bash my head against the table.
I changed
return View::make('users::index' , $id);
to
return Redirect::route('admin.users.index', $id);
and it worked
Level 65
Can I just ask why you had users::index in this line anyway? :P
return View::make('users::index' , $id);
Level 5
It's how you call a view when your using creo's module package. And from how I understand it, it's like this
return View::make('module::view', $id)
Level 65
Understood :)
Please or to participate in this conversation.