Eloquent Query Not Converting Correctly To Json

@casc-or i think since you are returning json trying to serialize the collection, have you tried to return array instead of json

 $members = Member::whereHas('memberships', function ($query) use ($id) {
            $query->where('club_id', '=', $id)
                ->where('date_expiry', '>=', Carbon::now())
                ->where('member_type_id', '=', 1);
        })->get()->sortBy('full_name')->pluck('id', 'full_name' );

return $members->toArray();

return $members->toArray();

returns the same result, actually.

Note that the collection from dd($members) if placed immediately after the query is run to create $members has no tags or field information either.

try this please

return json_encode(['members'=>$members->values()->all()]);

https://laravel.com/docs/5.3/collections#method-flatmap

FatalErrorException in ClubController.php line 96: syntax error, unexpected '=>' (T_DOUBLE_ARROW)

The solution is missing the array brackets []

return json([
    'members'=>$members->toArray()
]);

        return json([
            'members'=>$members->toArray()
        ]); 

gives

FatalErrorException in ClubController.php line 94: Call to undefined function App\Http\Controllers\json()

this should solve the issue

return json_encode(['members'=>$members->values()->all()]);

I'm pretty much convinced that the problem here stems from the result of this statement

 $members = Member::whereHas('memberships', function ($query) use ($id) {
            $query->where('club_id', '=', $id)
                ->where('date_expiry', '>=', Carbon::now())
                ->where('member_type_id', '=', 1);
        })->get()->sortBy('full_name')->pluck('id', 'full_name' );

which just returns a set of key => value pairs with no identifiers.

There must be some means of getting the same structure of output as Members::all();

return json_encode(['members'=>$members->values()->all()]);

doesn't solve it. That gives something which isn't recognized as json (because the Chrome add-in which formats json just shows it as text) which looks like this

{"members":[2628,2629,10197,2630,10201,2632, ... 2315,2316,2323,11628]}

i still can't understand where is the issue ,

    return json_encode(['members'=>$members->transform(function($member){

        return [ 'id' => @$member['id'],'full_name'=>@$member['full_name']];

    })]);

Perhaps I'm sending the discussion in the wrong direction here.

The end goal is to feed this;

    function loadPrimaryClubMem(club) {
        var primaryMem = $('#primary_membership_id');
        alert('loadPrimaryClubMem with ' + club + ' primary ' + primaryMem.val());
        $.ajax({
            url: "clubs/members/" + club,
            type: "GET",
            dataType: "json",
            success: function (data) {
                primaryMem.empty();
               $.each(data, function (key, value) {
                    primaryMem.append("<option value='" + key + "'>" + value + "</option>");
                });

            },
            error: function (data) {
                alert('was an error with data');
            }
        })
    }

This jQuery script gets called by a change event on a form select element. I'm then trying to populate another select on a form. I'm inspecting for a value from a select (club which is an id) and passing that to the url as a parameter. When I get the response back I'm wanting to empty and populate a select with the key / value pairs in the response.

So maybe what is being returned is the expected, but what I'm doing to handle it in jQuery is wrong?

I'm going to try a simpler query and just pluck from the Member::all() and see if that is read correctly.

i think there the index in ajax response will be ( 'members') and the key is full json array means you need to parse the data to get members object then do loop to start append in your dom

success: function (data) {
        var json_obj = $.parseJSON(data);//parse JSON

                primaryMem.empty();
               $.each(json_obj.members, function (key, value) {
                    primaryMem.append("<option value='" + key + "'>" + value + "</option>");
                });

            },

I'm going to try a simpler query and just pluck from the Member::all() and see if that is read correctly.

Nope. Makes no difference

you can check in dev tool if you are using google chrome, and console log the response of look at the get response results to know what you are receiving from server.

So, the first thing is that my url in the $.ajax call is wrong - it needs to be

$.ajax({
            url: "/clubs/members/" + club,

The original version without the preceeding slash is a relative path and was calling www.example.com/members/clubs/members/{id} which is of course not what I want.

The next thing is that using pluck is a problem. If I change the query to not use pluck then use the syntax @khaledSMQ suggested

        return json_encode(['members' => $members->transform(function ($member) {

            return [ 'id' => @$member['id'],'full_name'=>@$member['full_name']];

        })]);

I get correctly formed json passed to my script. Finally, the jQuery syntax needs to be slightly different to that @khaledSMQ suggested.

success: function (data) {
                primaryMem.empty();
               $.each(data.members, function () {
                    primaryMem.append("<option value='" + this.id + "'>" + this.full_name + "</option>");
                });

            }

With the correctly formed response, it isn't necessary to .parseJSON the response, and it is necessary to use the 'this' keyword to reference the objects in the $.each statement.

So finally all this worked. Thanks to all for the clues and hopefully this TL;DR; thread will help someone else with a similar problem in future.