Eloquent closures insert to query - "SELECT *" and "is null"

This was the only simplified example to show where this select * is inserting. I used the closer to grouping OR WHERE statement, so:

This code:

$results = Product::where('category', '=', 'Trousers')->where(function($query) {
	$query->orWhere('color', '=', 'Red')->orWhere('color', '=', 'Black')
 });

should genetate SQL like this:

select * from `products` where `products`.`category` = 'Trousers' and (select * `products`.`color` =  'Red' or `products`.`color` =  'Black')

while I'm getting this:

select * from `products` where `products`.`category` = 'Trousers' and (select * `products`.`color` =  'Red' or `products`.`color` =  'Black') is null

So as you see this select * inside the brackets is not needed.

Here in the documentation is the example about my scenario (group an "or" condition within parentheses) and it looks simillar: https://laravel.com/docs/8.x/queries#or-where-clauses

One more observation I tested now. If I do the same this way:

$users = DB::table('products')
->where('category', '=', 'Trousers')
->where(function($query) {
	$query->orWhere('color', '=', 'Red')->orWhere('color', '=', 'Black')
 });

the SQL output is correct. Why it's a dirret now for Eloquent models?

@gpi I just upgraded version 5.8 to 8 and have the exact same problem. It's been 2 years since you posted it here, but I'll still ask if you found out why it's happening. Would highly appreciate any help.

@gpi I found the problem, you are probably using sofa/eloquence package. Its query builder class reassigns the $operator parameter to '=' prior to passing the control back to the Eloquent query builder because of which Eloquent treats the query as a regular select on a column and correspondingly adds the missing select clause. I'm submitting a bug to the sofa/eloquence repo right now.

There already is an issue in their repo for the problem https://github.com/jarektkaczyk/eloquence-base/issues/31

@maqduni Yeah, I found the same and I had to eliminate sofa/eloquence package from the project.