Hey all,
For my website I currently have three user roles ["admin", "contractor", "user"]
On my register page I have two radio button's that allow the user to select which account type they wish to create an account for. I feel the way I have coded the logic that switches validation logic etc is messy and was wondering if anyone would have any tips on how to improve it.
<?php
namespace App\Http\Controllers\Auth;
use App\User;
use Validator;
use App\Http\Controllers\Controller;
use Illuminate\Foundation\Auth\ThrottlesLogins;
use Illuminate\Foundation\Auth\AuthenticatesAndRegistersUsers;
class AuthController extends Controller
{
/*
|--------------------------------------------------------------------------
| Registration & Login Controller
|--------------------------------------------------------------------------
|
| This controller handles the registration of new users, as well as the
| authentication of existing users. By default, this controller uses
| a simple trait to add these behaviors. Why don't you explore it?
|
*/
use AuthenticatesAndRegistersUsers, ThrottlesLogins;
/**
* Where to redirect users after login / registration.
*
* @var string
*/
protected $redirectTo = '/';
/**
* Create a new authentication controller instance.
*
* @return void
*/
public function __construct()
{
$this->middleware('guest', ['except' => 'logout']);
}
/**
* Get a validator for an incoming registration request.
*
* @param array $data
* @return \Illuminate\Contracts\Validation\Validator
*/
protected function validator(array $data)
{
$rules = [
'user' => [
'first_name' => 'required|max:40',
'last_name' => 'required|max:40',
'email' => 'required|email|max:255|unique:users',
'password' => 'required|confirmed|min:6',
'type' => 'required'
],
'contractor' => [
'first_name' => 'required|max:255',
'last_name' => 'required|max:255',
'contractor_name' => 'required|max:255',
'email' => 'required|email|max:255|unique:users',
'password' => 'required|confirmed|min:6',
'type' => 'required'
]
];
$data['type'] = (isset($data['type']) && in_array($data['type'], [2,3])) ? $data['type'] : 3;
if($data['type'] == 2) {
return Validator::make($data, $rules['contractor']);
} elseif($data['type'] == 3) {
return Validator::make($data, $rules['user']);
}
}
/**
* Create a new user instance after a valid registration.
*
* @param array $data
* @return User
*/
protected function create(array $data)
{
if($data['type'] == 3) {
$user = User::create([
'first_name' => $data['first_name'],
'last_name' => $data['last_name'],
'email' => $data['email'],
'password' => bcrypt($data['password']),
]);
$user->assignRole('user');
} elseif($data['type'] == 2) {
$user = User::create([
'first_name' => $data['first_name'],
'last_name' => $data['last_name'],
'contractor_name' => $data['contractor_name'],
'slug' => str_slug($data['contractor_name']),
'email' => $data['email'],
'password' => bcrypt($data['password']),
]);
$user->assignRole('contractor_name');
}
return $user;
}
}
Thanks!