Level 2
Doc here
Oct 31, 2016
9
Level 1
File Uploading!
Hi, Please, I need a bit of help with file uploading. This is what I am trying to achieve with my snippet of code of file uploading:
- Saving the photo in a directory (seems problematic).
- Saving the photo's link in the database (solved, but i welcome you suggestion if there is a better way). Below is my code:
public function store(BlogRequest $request) {
$request = $request->all();
$request['picture'] = "/pictureStorage/" . $request['picture'];
Blog::create($request);
// The issue part
$name = $request->file('picture')->getClientOriginalName();
if($request->file('picture')->move('pictureStorage/ourFile', $name)){
return 'File was moved.'. 'you are now in'.URL::previous();
}else{
return "Something horrible went wrong!";
}
}
Level 1
Thank you, @habeebnet.
I have modified my code to:
$request = $request->all();
$request['picture'] = "/pictureStorage/" . $request['picture'];
Blog::create($request);
if($request->hasFile('picture')){
$request->file('picture')->store('images');
}else{
return "file not found";
}
Actually, the error I am receiving is : "Call to a member function hasFile('picture') on array".
I understand that I may be calling the method the wrong way, so what is the correct way?
Thank you.
Level 32
$req = $request;
$request = $request->all();
$request['picture'] = "/pictureStorage/" . $request['picture'];
Blog::create($request);
if($req ->hasFile('picture')){
$req ->file('picture')->store('images');
}else{
return "file not found";
}
Level 16
Consider using the Storage Facade for storing your files, this will ensure they land where you want them to and you can catch any unwanted exceptions
Also consider uploading the images in a separate call than creating your Blog this will allow you to validate the image before creating the Blog and when you finally create the blog, all you need to do is attach the id/path of the image.
1 like
Level 16
Change your db table column name 'picture' to 'picture_file' Not tested.. but this should work
.. What? the database has nothing to do with the file field
if you want to access $request->picture then your input must have name="picture". It has nothing to do with the database
Level 1
@habeebnet , thank you for the input, but i don't believe that's a correct one.
Level 1
@WebKenth , thank you for the recommendation. I will work on that.
Level 2
@Deshola I highly recommend you to go through these videos - https://laracasts.com/series/simple-rules-for-simpler-code
Using same variable name (or array key) for multiple things is not a best practice, that's why I recommended you to change your column name and that one step will solve your issue.
Level 1
@habeebnet , Yes, I got your point. Actually, I am not a beginner in PHP programing, but Laravel. I am aware of the best practice, the snippet of code is just to try something out....like, the bigger picture is hidden. Thank you for the input.
Please or to participate in this conversation.