Level 102
Please show Type_MonsterController. I assume its the show route you are referring to causing the issue?
Feb 11, 2025
7
Level 1
Circular redirection in Laravel
When an entry is opened by id, a round-robin redirection occurs. I can't figure out what the problem is.
Route::middleware("admin")->group(function() {
Route::get("/admin", [AdminController::class, 'up'])->name("admin");
Route::name("type_monsters")->controller(Type_MonsterController::class)->group(function () {
Route::get("/type_monsters", "up");
Route::post("/type_monsters/add", "store")->name(".store");
Route::get("/type_monsters/{bb}/show", "show")->name(".show");
});
});
Here is the middleware that is used:
public function handle(Request $request, Closure $next): Response
{
if (!Auth::check()) {
return redirect()->route("auth.login");
}
$role = Auth::user()->role_id;
if ($role !== 1) {
abort(403, 'Forbidden');
}
return $next($request);
}
Is that the case, or is there something else that can cause this behavior? Laravel 11
Level 102
Also if you have ANY other routes before these, there is a chance you are hitting one of them.
Level 1
Type_MonsterController:
<?php
namespace App\Http\Controllers;
use Illuminate\Http\Request;
use App\Models\Type_Monster;
use Illuminate\Support\Facades\Validator;
class Type_MonsterController extends Controller
{
public function up(){
$data = Type_Monster::all();
if ($data->isNotEmpty()) {
return view("admin.type_monsters", ['types' => $data]);
}
else {
return view("admin.type_monsters", ['types' => false]);
}
}
private function rules() {
return [
"size" => "integer"
];
}
private function message() {
return [
"size.integer" => "В поле с размером, должны быть только числа"
];
}
public function store(Request $request) {
$validate = Validator::make(
$request->all(),
$this->rules(),
$this->message()
);
// $val = $validate->validate();
if ($validate->passes()) {
$bb = new Type_Monster($request->all());
$bb->save();
return back()->with(['message' => "Success!"]);
}
elseif($validate->fails()) {
return back()->with(['message' => $validate->errors()]);
}
}
public function show(Type_Monster $id) {
return redirect()->route("type_monsters.show", ['id' => $id]);
}
}
Level 102
@Bakamashine This just redirects to itself?
public function show(Type_Monster $id) {
return redirect()->route("type_monsters.show", ['id' => $id]);
}
I assume you want to return a view instead of a redirect
1 like
Level 104
@bakamashine you are also using Route-Model binding incorrectly; the parameter on the Controller action ($id) should match the wildcard parameter in the URL {bb}, otherwise you will get an "empty" Type_Monster instance - that does not exist in the database:
Route::get("/type_monsters/{monster}/show", "show")->name(".show");
public function show(Type_Monster $monster) {
return view('monsters,show', ['monster' => $monster]);
}
1 like
Level 1
@Sinnbeck Thank you!
Level 104
When an entry is opened by id
What does this mean; which route are you visiting?
Please or to participate in this conversation.