Be part of JetBrains PHPverse 2026 on June 9 – a free online event bringing PHP devs worldwide together.

bmrbehnam's avatar

Seeking Clarity on Laravel Pull Request Acceptance Criteria

Hello Laravel Developers,

I hope this post finds you well. I recently submitted a pull request that I believe brings significant improvements to Laravel's functionality. However, the request has not been accepted, prompting me to seek insights and understanding from the community.

My pull request focuses on enhancing the efficiency and flexibility of the updateOrCreate method, addressing common limitations faced in real-world scenarios. Despite its potential benefits, it has yet to be merged into the Laravel framework.

This has led me to ponder: Why does the Laravel team sometimes refrain from accepting seemingly good pull requests or integrating new code?

I acknowledge the team's commitment to maintaining a high-quality codebase, and I genuinely respect their decisions. However, I believe open communication within the community is vital for mutual understanding and growth.

As Laravel developers, we value efficiency, elegance, and the constant evolution of our beloved framework. My intention is not to criticize but to foster a constructive dialogue about the criteria or considerations that guide the acceptance of pull requests and the integration of new code.

If you've had similar experiences or insights, or if you're part of the Laravel team and can shed light on this, I'd greatly appreciate your thoughts. Let's engage in a respectful and informative discussion to better comprehend the decision-making process behind pull request acceptance and new code integration.

Thank you for your time and contribution to this discussion.

0 likes
2 replies
Snapey's avatar

what was their response?

{Perhaps link to the PR)

Please or to participate in this conversation.